Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't read a few files #42

Open
Trevahok opened this issue Sep 2, 2020 · 7 comments
Open

Doesn't read a few files #42

Trevahok opened this issue Sep 2, 2020 · 7 comments

Comments

@Trevahok
Copy link

Trevahok commented Sep 2, 2020

Certifications, Phone Number, Patents, Honors aren't read and converted. Please have a look.

@JMPerez
Copy link
Owner

JMPerez commented Sep 6, 2020

@Trevahok Could you please show an example? It would be useful that you provided the source file from LinkedIn and the expected output in JSON Resume.

Thanks!

@Trevahok
Copy link
Author

Trevahok commented Sep 7, 2020

It’s a lot of personal data :(
Any possibility I can DM you ?

@JMPerez
Copy link
Owner

JMPerez commented Sep 7, 2020

@Trevahok You can send it to me at jmperez1985@gmail.com

@Trevahok
Copy link
Author

Trevahok commented Sep 7, 2020

Done! Please have a look!

@JMPerez
Copy link
Owner

JMPerez commented Sep 13, 2020

Hi @Trevahok,

I had a look at the files, and you are definitely right. The are not being converted, but it's also true that some of them are not part of the JSON Resume standard. That's the case for certifications, patents, and honors.

I will be fixing the phone number, since that's something it is supported on JSON Resume.

@Trevahok
Copy link
Author

That sounds amazing!
As an afterthought, can Honors be fit into the ‘awards’ key ?

@housamz
Copy link
Contributor

housamz commented Aug 12, 2024

I added all the files to #66, matching the recent updates to JSON Resume Format.
I hope my pull request closes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants