Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE/TEST] DTO Validation test #358

Merged
merged 6 commits into from
Jul 7, 2024
Merged

[BE/TEST] DTO Validation test #358

merged 6 commits into from
Jul 7, 2024

Conversation

LJH098
Copy link
Collaborator

@LJH098 LJH098 commented Jul 4, 2024

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

closes #353

๐Ÿ”‘ ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • CreateFoodRequest Valid test ์ง„ํ–‰
  • LoginRequest Valid test ์ง„ํ–‰
  • OnBoardingRequest Valid test ์ง„ํ–‰

@LJH098 LJH098 added the BE label Jul 4, 2024
@LJH098 LJH098 requested a review from hwangdaesun July 4, 2024 07:09
@LJH098 LJH098 self-assigned this Jul 4, 2024
@LJH098 LJH098 linked an issue Jul 4, 2024 that may be closed by this pull request
[BE/TEST] DTO Validation ํ…Œ์ŠคํŠธ #353
Closed
3 tasks
hwangdaesun
hwangdaesun reviewed Jul 4, 2024
View reviewed changes
BE/exceed/src/test/java/com/gaebaljip/exceed/food/CreateFoodIntegrationTest.java
import com.gaebaljip.exceed.common.WithMockUser;
import com.gaebaljip.exceed.dto.request.CreateFoodRequest;

class CreateFoodIntegrationTest extends IntegrationTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DTO Validation Test๊ฐ€ ๋ชฉ์ ์ด๋ฉด, Controller ๊ณ„์ธต๋งŒ ํ…Œ์ŠคํŠธํ•˜๋Š” ๊ฑด ์–ด๋–ค๊ฐ€์š”?
๋งŒ์•ฝ ๊ทธ๋ ‡๋‹ค๋ฉด, ControllerTest ํด๋ž˜์Šค๋ฅผ ์ƒ์†๋ฐ›์œผ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๊ฒŒ ์ข‹๊ฒ ๋„ค์š”

hwangdaesun
hwangdaesun approved these changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@hwangdaesun hwangdaesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@hwangdaesun hwangdaesun merged commit c494ed8 into be Jul 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

Overall Project 50.43% โŒ
File Coverage
CreateFoodController.java 100% ๐Ÿ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangdaesun hwangdaesun hwangdaesun approved these changes

Assignees

@LJH098 LJH098

Labels
BE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE/TEST] DTO Validation ํ…Œ์ŠคํŠธ
2 participants
@LJH098 @hwangdaesun