Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Be/fix] 특정 날짜의 식사 정보 조회하는 API 오류 수정 #425

Closed
8 tasks done
hwangdaesun opened this issue Jul 22, 2024 · 0 comments
Closed
8 tasks done

[Be/fix] 특정 날짜의 식사 정보 조회하는 API 오류 수정 #425

hwangdaesun opened this issue Jul 22, 2024 · 0 comments
Assignees
@hwangdaesun
Labels
BE bug Something isn't working refactor test
Milestone
BE_daesun

Comments

@hwangdaesun
Copy link
Collaborator

hwangdaesun commented Jul 22, 2024 •
edited
Loading

⚠️ Issue

  • 현재 특정 날짜의 회원 정보를 찾을 때 특정 날짜에

✏️ To Do List

  • testData.sql 회원가입, 온보딩, 회원 수정 FLOW 고려해서 수정(특히 날짜 및 시간)
  • 회원 수정 updatedAt 검증 추가
  • CustomMemberRepositoryImpl의 findByMemberIdAndDate메서드 구현 수정 및 메서드 명 변경
  • CustomHistoryRepositoryImpl의 findByMemberIdAndDate 메서드 구현 수정 및 메서드 명 변경
  • CustomMemberRepositoryImpl 클래스 테스트
  • CustomHistoryRepositoryImpl 클래스 테스트
  • 특정 날짜의 식사 정보 조회하는 API 통합 테스트 보충
  • 회원가입한 날짜보다 전의 켈린더 조회하는 경우 Validate하는 Usecase 개발

ETC

🏞 ScreenShot

  • Add any other context or screenshots about the feature request here.
@hwangdaesun hwangdaesun added bug Something isn't working BE refactor test labels Jul 22, 2024
@hwangdaesun hwangdaesun added this to the BE_daesun milestone Jul 22, 2024
@hwangdaesun hwangdaesun self-assigned this Jul 22, 2024
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : 실제 회원가입 및 온보딩 그리고 회원수정 Flow에 맞게 수정
0004ddf
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
fix/#425 : checkDate 메서드를 updatedAt 기준으로 해당 날짜보다 과거에 있는 것 확인하도록 수정
8c1fc84
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : findMemberBeforeDate 메서드 테스트
b05ebd0
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
fix/#425 : 미래중 가장 가까운 기록을 찾도록 메서드 수정
7bd2fc5
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : findMostRecentFutureMember 메서드 테스트
c7dd1d4
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
refactor/#425 : CustomMemberRepositoryImpl, CustomHistoryRepositoryIm…
43ca70d 
…pl 메서드 수정으로 인한 변경사항 반영
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : 회원 수정 통합 테스트 보충
1bf09fd
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : testData.sql 수정으로 인한 변경
281a5af
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
feat/#425 : 켈린더 조회시 회원 가입 전의 날짜를 조회하는 경우 validate 하는 Usecase 개발
c626d57
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : @MockBean 추가
a9a19e7
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : 날짜와 식사 기록 유무에 따라서 켈린더 상세 조회 테스트 추가 및 수정
7236874
@hwangdaesun hwangdaesun mentioned this issue Jul 22, 2024
Merged
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
refactor/#425 : createdDate -> id로 수정
ee549e3
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
test/#425 : 메서드명 when~expected로 수정
a6982b5
hwangdaesun added a commit that referenced this issue Jul 22, 2024
@hwangdaesun
Merge pull request #427 from JNU-econovation/fix/#425
764e34f 
[Be/fix] 특정 날짜의 식사 정보 조회하는 API 오류 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwangdaesun hwangdaesun

Labels
BE bug Something isn't working refactor test
Projects
None yet
Milestone
BE_daesun
Development

No branches or pull requests
1 participant
@hwangdaesun