[BE/TEST] 각종 테스트 #376
Merged
[BE/TEST] 각종 테스트 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Swagger 요청은 로깅 안되게 수정
- 회원 탈퇴 데이터 검증
hwangdaesun
reviewed
Jul 12, 2024
Comment on lines
35
to
36
| resultActions.andExpect(status().isOk()); | ||
| assertAll(() -> assertFalse(memberRepository.existsById(memberId))); |
There was a problem hiding this comment.
회원 탈퇴시 회원 이외에도 제거되는 데이터들도 검증에 포함되어 있으면 좋을 것 같습니다.
There was a problem hiding this comment.
그런데 굳이 이벤트까지 써가면서 결합도를 낮췄는데 테스트에서 결합도를 높일 필요가 있나 싶어요
Controller 테스트에서 이벤트가 잘 publish되는지 테스트도 하고 있어서 굳이 다른 데이터가 삭제 되었는지 확인 할필요 없지않나
There was a problem hiding this comment.
테스트의 목적이 해당 기능이 의도하는 데로 확인하는 거 아닌가요?
결합도가 올라간다고 통합 테스트시 해야갈 검증을 안 하는 거는 옳지 않다고 생각합니다.
hwangdaesun
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closes #359
🔑 주요 변경사항