Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with mdx-deck v2 #12

Open
4 tasks
JReinhold opened this issue Jul 17, 2019 · 2 comments
Open
4 tasks

Doesn't work with mdx-deck v2 #12

JReinhold opened this issue Jul 17, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JReinhold
Copy link
Owner

The current iteration of mdx-deck-live-code was made for mdx-deck@1.x, and doesn't seem to work with mdx-deck@2.x. Another unfortunate consequence of this, is that it doesn't work with the CodeSandbox mdx-deck template.

The main reason it doesn't work, is the fact that mdx-deck switched from styled-components to emotion in version 2. There may be other reasons it doesn't work, but at the moment that is the only one I know of.

To fix this, a (non exhaustive) todo list could look like:

  • Migrate from styled-components to emotion
  • Bump mdx-deck-live-code to v2, as this is probably a breaking change
  • Note in the README.md which versions support which versions of mdx-deck
  • Migrate to react-live@2.x as well, unless it is so big a change that it needs it's own PR.

Everyone is welcomed to give this a go.

@JReinhold JReinhold added bug Something isn't working good first issue Good for newcomers labels Jul 17, 2019
@uyarn
Copy link

uyarn commented Aug 24, 2020

would like to implement it

@JReinhold
Copy link
Owner Author

JReinhold commented Aug 25, 2020

would like to implement it

Awesome, go ahead! Let me know if you need any pointers beyond the initial todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants