Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not overriding babel-runtime's Promise #171

Open
UltCombo opened this issue Aug 3, 2015 · 0 comments
Open

Consider not overriding babel-runtime's Promise #171

UltCombo opened this issue Aug 3, 2015 · 0 comments

Comments

@UltCombo
Copy link
Member

UltCombo commented Aug 3, 2015

We currently override babel-runtime's Promise in Harmonic's CLI mode so that we can report unhandled promise rejections in Node.js (io.js supports this natively).

We should remove this hack once Node.js and io.js are merged and Node.js 0.10-0.12 are deprecated or obsolete. But until then, we should at least add unit tests to make sure this is working as intended.

Note: The Harmonic API will return promises, so the error handling is up to the consumer in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant