From 1d98e9a3a78be840dea04c423d39ba65799e0177 Mon Sep 17 00:00:00 2001 From: JunsuChoi Date: Tue, 19 Mar 2024 15:42:38 +0900 Subject: [PATCH] [Tizen] Disable download fuchsia sdk The size of fuchsia sdk has increased from 2.3G to 6.4G. As a result, a no memory error occurs in CI. So apply some of this commit. https://github.com/flutter/engine/commit/1e199ce6239d191a7d200d83a21da72dab9ea4f2 Add the download_fuchsia_deps flag and set this flag to False in ci. --- .github/workflows/build.yml | 2 +- DEPS | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 20fe40356344e..dca33021036de 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -47,7 +47,7 @@ jobs: - name: Run gclient sync run: | gclient config --name=src/flutter --unmanaged https://github.com/flutter-tizen/engine - gclient setdep --var=download_dart_sdk=False --var=download_android_deps=False --deps-file=src/flutter/DEPS + gclient setdep --var=download_dart_sdk=False --var=download_android_deps=False --var=download_fuchsia_deps=False --deps-file=src/flutter/DEPS gclient sync -v --no-history --shallow - name: Generate sysroot diff --git a/DEPS b/DEPS index 0a36f9bbf3547..854b884286ee0 100644 --- a/DEPS +++ b/DEPS @@ -106,6 +106,13 @@ vars = { # Checkout Linux dependencies only when building on Linux. 'download_linux_deps': 'host_os == "linux"', + # Checkout Fuchsia dependencies only on Linux. This is the umbrella flag which + # controls the behavior of all fuchsia related flags. I.e. any fuchsia related + # logic or condition may not work if this flag is False. + # TODO(zijiehe): Make this condition more strict to only download fuchsia + # dependencies when necessary: b/40935282 + 'download_fuchsia_deps': 'host_os == "linux"', + # Downloads the fuchsia SDK as listed in fuchsia_sdk_path var. This variable # is currently only used for the Fuchsia LSC process and is not intended for # local development. @@ -938,7 +945,7 @@ deps = { 'version': 'I-3hiLjX2DDy6mu22Q51o4ktda9zg0wZWdk-QolLicoC' } ], - 'condition': 'host_os == "linux" and not download_fuchsia_sdk', + 'condition': 'download_fuchsia_deps and not download_fuchsia_sdk', 'dep_type': 'cipd', }, @@ -1032,7 +1039,7 @@ hooks = [ { 'name': 'Download Fuchsia SDK', 'pattern': '.', - 'condition': 'download_fuchsia_sdk', + 'condition': 'download_fuchsia_deps and download_fuchsia_sdk', 'action': [ 'python3', 'src/flutter/tools/download_fuchsia_sdk.py',