Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the stack trace of re-thrown exceptions #57

Merged
merged 5 commits into from
Sep 18, 2019

Conversation

JSkimming
Copy link
Owner

@JSkimming JSkimming commented Apr 9, 2019

Fixes #41

TODO

  • Add representative unit tests.

@JSkimming JSkimming self-assigned this Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@172b157). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #57   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      5           
  Lines             ?    229           
  Branches          ?      9           
=======================================
  Hits              ?    229           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
...stle.Core.AsyncInterceptor/AsyncInterceptorBase.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172b157...cccef95. Read the comment docs.

@JSkimming JSkimming force-pushed the retain-exception-stack branch 3 times, most recently from af7ce6d to aa00072 Compare April 11, 2019 21:15
@bkaid
Copy link

bkaid commented Sep 11, 2019

Would be quite helpful to get this released.

@JSkimming JSkimming force-pushed the retain-exception-stack branch 3 times, most recently from cccef95 to 25ad7f2 Compare September 18, 2019 16:07
@JSkimming JSkimming merged commit c7c5367 into master Sep 18, 2019
@JSkimming JSkimming deleted the retain-exception-stack branch September 18, 2019 16:48
@JSkimming
Copy link
Owner Author

@bkaid This has just been released, and can be pulled via NuGet.

https://www.nuget.org/packages/Castle.Core.AsyncInterceptor/2.0.1-alpha

@bkaid
Copy link

bkaid commented Sep 19, 2019

Had already seen the release was made and validated it against a code base that makes use of it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacktrace lost in synchronous interception due to rethrow "throw task.Exception.InnerException"
2 participants