Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for Linux and Mac #405

Open
tobiasdiez opened this issue Jan 23, 2022 · 4 comments
Open

Improve error messages for Linux and Mac #405

tobiasdiez opened this issue Jan 23, 2022 · 4 comments

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Jan 23, 2022

With #404 now a detailed error page is displayed in case something went wrong with the "native messaging" to JabRef.
image

I've tested in Firefox and Chrome on Windows. However, it is not yet tested on Mac and Linux. Help for this is very much appreciated.

What you can do to help:

  • For each step outlined in the manual installation instructions at https://docs.jabref.org/collect/jabref-browser-extension#installation-and-configuration, do the following:
    • Break what is written there (e.g. rename the org.jabref.jabref.json)
    • Try to import a webpage into JabRef. This should fail now and the error page should show.
    • Check if the instructions on the error page are pointing to the right issue (in the example above, they should tell you to check the path of the json file)
    • If that's not the case, please comment here with what you did, what the exception message was and what you would have expected.

Thanks a lot for your help!

cc @LyzardKing

@LyzardKing
Copy link
Collaborator

Looks good @tobiasdiez!
I'll test it as soon as possible.

@da-ekchajzer
Copy link

da-ekchajzer commented Mar 10, 2023

Works for me.

shouldn't it be :

No such native application org.jabref.jabref .json

Screenshot_20230310_152231

@tobiasdiez
Copy link
Member Author

Thanks, this is helpful. The error message should indeed give a list of possible causes and how to fix them (as in the first screenshot above, which is from the windows version). So here you changed the name of the json file?

What error is reported if you change the path variable to a non-existing path in the org.jabref.jabref.json file?

@da-ekchajzer
Copy link

Yep, in the above example, I have changed the name of the JSON file. I get the same screen when changing the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants