Merge pull request #4642 from RonakLakhotia/edition-checker

[#4591] Add Integrity check for books with edition reported as 1
JabRef · Feb 13, 2019 · 4844541 · 4844541
2 parents 80192eb + b858a2c
commit 4844541
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/src/main/java/org/jabref/logic/integrity/EditionChecker.java b/src/main/java/org/jabref/logic/integrity/EditionChecker.java
@@ -14,6 +14,7 @@ public class EditionChecker implements ValueChecker {
     private static final Predicate<String> FIRST_LETTER_CAPITALIZED = Pattern.compile("^[A-Z]").asPredicate();
     private static final Predicate<String> ONLY_NUMERALS_OR_LITERALS = Pattern.compile("^([0-9]+|[^0-9].+)$")
             .asPredicate();
+    private static final String FIRST_EDITION = "1";
 
     private final BibDatabaseContext bibDatabaseContextEdition;
 
@@ -38,6 +39,10 @@ public Optional<String> checkValue(String value) {
             return Optional.empty();
         }
 
+        if (value.equals(FIRST_EDITION)) {
+            return Optional.of(Localization.lang("edition of book reported as just 1"));
+        }
+
         //biblatex
         if (bibDatabaseContextEdition.isBiblatexMode() && !ONLY_NUMERALS_OR_LITERALS.test(value.trim())) {
             return Optional.of(Localization.lang("should contain an integer or a literal"));

diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
@@ -1944,6 +1944,7 @@ Sumatra\ Reader=Sumatra Reader
 shared=shared
 should\ contain\ an\ integer\ or\ a\ literal=should contain an integer or a literal
 should\ have\ the\ first\ letter\ capitalized=should have the first letter capitalized
+edition\ of\ book\ reported\ as\ just\ 1=edition of book reported as just 1
 Tools=Tools
 What\'s\ new\ in\ this\ version?=What\'s new in this version?
 Want\ to\ help?=Want to help?

diff --git a/src/test/java/org/jabref/logic/integrity/IntegrityCheckTest.java b/src/test/java/org/jabref/logic/integrity/IntegrityCheckTest.java
@@ -84,6 +84,7 @@ void testEditionChecks() {
                 withMode(createContext("edition", "Third, revised and expanded edition"), BibDatabaseMode.BIBLATEX));
         assertCorrect(withMode(createContext("edition", "Edition 2000"), BibDatabaseMode.BIBLATEX));
         assertWrong(withMode(createContext("edition", "2nd"), BibDatabaseMode.BIBLATEX));
+        assertWrong(createContext("edition", "1"));
     }
 
     @Test