From 5a114125362bd74415ec59d57fac874896460ac1 Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Mon, 1 Feb 2021 21:19:59 +0100 Subject: [PATCH] Grand unified preferences dialog (#7384) Co-authored-by: Siedlerchr --- CHANGELOG.md | 1 + src/main/java/org/jabref/gui/JabRefFrame.java | 15 --- .../CitationKeyPatternPanel.java | 14 ++- .../CitationKeyPatternPanelViewModel.java | 31 +++-- .../CustomizeGeneralFieldsDialog.fxml | 24 ---- .../CustomizeGeneralFieldsDialogView.java | 64 ----------- .../SetupGeneralFieldsAction.java | 15 --- .../exporter/ExportCustomizationDialog.fxml | 28 ----- .../ExportCustomizationDialogView.java | 63 ----------- .../exporter/ManageCustomExportsAction.java | 15 --- .../importer/ImportCustomizationDialog.fxml | 22 ---- .../importer/ManageCustomImportsAction.java | 18 --- .../journals/ManageJournalAbbreviations.fxml | 71 ------------ .../gui/journals/ManageJournalsAction.java | 15 --- .../keyboard/CustomizeKeyBindingAction.java | 15 --- .../gui/keyboard/KeyBindingRepository.java | 35 ++++-- .../gui/keyboard/KeyBindingsDialog.fxml | 33 ------ .../AbstractPreferenceTabView.java | 3 +- .../preferences/PreferenceTabViewModel.java | 9 +- .../gui/preferences/PreferencesDialog.css | 2 +- .../gui/preferences/PreferencesDialog.fxml | 4 +- .../preferences/PreferencesDialogView.java | 2 + .../PreferencesDialogViewModel.java | 51 ++++++--- .../gui/preferences/PreferencesTab.java | 2 +- .../{ => appearance}/AppearanceTab.fxml | 9 +- .../AppearanceTab.java} | 25 ++--- .../AppearanceTabViewModel.java | 3 +- .../CitationKeyPatternTab.fxml | 13 ++- .../CitationKeyPatternTab.java} | 52 ++++----- .../CitationKeyPatternTabViewModel.java | 16 +-- .../{ => entryeditor}/EntryEditorTab.fxml | 8 +- .../EntryEditorTab.java} | 12 +- .../EntryEditorTabViewModel.java | 8 +- .../CustomEditorFieldsTab.fxml | 33 ++++++ .../CustomEditorFieldsTab.java | 47 ++++++++ .../CustomEditorFieldsTabViewModel.java} | 38 ++++--- .../exporter/ExportCustomizationTab.fxml | 31 +++++ .../exporter/ExportCustomizationTab.java | 65 +++++++++++ .../ExportCustomizationTabViewModel.java} | 34 +++--- .../{ => external}/ExternalTab.fxml | 14 +-- .../ExternalTab.java} | 15 +-- .../{ => external}/ExternalTabViewModel.java | 11 +- .../gui/preferences/{ => file}/FileTab.fxml | 9 +- .../{FileTabView.java => file/FileTab.java} | 27 +---- .../{ => file}/FileTabViewModel.java | 14 +-- .../preferences/{ => general}/GeneralTab.fxml | 7 +- .../GeneralTab.java} | 13 +-- .../{ => general}/GeneralTabViewModel.java | 7 +- .../preferences/{ => groups}/GroupsTab.fxml | 7 +- .../GroupsTab.java} | 13 +-- .../{ => groups}/GroupsTabViewModel.java | 16 +-- .../importer/ImportCustomizationTab.fxml | 30 +++++ .../importer/ImportCustomizationTab.java} | 60 +++++----- .../ImportCustomizationTabViewModel.java} | 36 +++--- .../journals/AbbreviationViewModel.java | 2 +- .../journals/AbbreviationsFileViewModel.java | 2 +- .../journals/JournalAbbreviationsTab.css} | 0 .../journals/JournalAbbreviationsTab.fxml | 67 +++++++++++ .../journals/JournalAbbreviationsTab.java} | 54 ++++----- .../JournalAbbreviationsTabViewModel.java} | 106 ++++++++++-------- .../keybindings}/KeyBindingViewModel.java | 5 +- .../keybindings/KeyBindingsTab.css} | 0 .../keybindings/KeyBindingsTab.fxml | 41 +++++++ .../keybindings/KeyBindingsTab.java} | 49 +++----- .../keybindings/KeyBindingsTabViewModel.java} | 59 ++++++---- .../presets/BashKeyBindingPreset.java | 2 +- .../presets/KeyBindingPreset.java | 2 +- .../{ => linkedfiles}/LinkedFilesTab.fxml | 21 +++- .../LinkedFilesTab.java} | 13 +-- .../LinkedFilesTabViewModel.java | 10 +- .../NameFormatterItemModel.java | 2 +- .../{ => nameformatter}/NameFormatterTab.fxml | 5 +- .../NameFormatterTab.java} | 13 +-- .../NameFormatterTabViewModel.java | 13 +-- .../preferences/{ => network}/NetworkTab.fxml | 8 +- .../NetworkTab.java} | 15 ++- .../{ => network}/NetworkTabViewModel.java | 3 +- .../preferences/{ => preview}/PreviewTab.fxml | 7 +- .../PreviewTab.java} | 18 +-- .../{ => preview}/PreviewTabViewModel.java | 12 +- .../NewProtectedTermsFileDialog.java | 20 ++-- .../protectedterms/ProtectedTermsTab.fxml | 31 +++++ .../protectedterms/ProtectedTermsTab.java} | 36 +++--- .../ProtectedTermsTabViewModel.java} | 68 ++++++++--- .../gui/preferences/{ => table}/TableTab.fxml | 13 ++- .../TableTab.java} | 15 ++- .../{ => table}/TableTabViewModel.java | 8 +- .../preferences/{ => xmp}/XmpPrivacyTab.fxml | 13 ++- .../XmpPrivacyTab.java} | 13 +-- .../{ => xmp}/XmpPrivacyTabViewModel.java | 10 +- .../ManageProtectedTermsAction.java | 15 --- .../ManageProtectedTermsDialog.fxml | 36 ------ src/main/resources/l10n/JabRef_en.properties | 14 +-- ...nsViewModelMixedAbbreviationsTabTest.java} | 11 +- ...NoShortestUniqueAbbreviationsTabTest.java} | 11 +- ...thShortestUniqueAbbreviationsTabTest.java} | 11 +- ...Test.java => KeyBindingsTabModelTest.java} | 24 ++-- .../jabref/logic/l10n/LocalizationParser.java | 9 ++ 98 files changed, 997 insertions(+), 1115 deletions(-) delete mode 100644 src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialog.fxml delete mode 100644 src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialogView.java delete mode 100644 src/main/java/org/jabref/gui/customizefields/SetupGeneralFieldsAction.java delete mode 100644 src/main/java/org/jabref/gui/exporter/ExportCustomizationDialog.fxml delete mode 100644 src/main/java/org/jabref/gui/exporter/ExportCustomizationDialogView.java delete mode 100644 src/main/java/org/jabref/gui/exporter/ManageCustomExportsAction.java delete mode 100644 src/main/java/org/jabref/gui/importer/ImportCustomizationDialog.fxml delete mode 100644 src/main/java/org/jabref/gui/importer/ManageCustomImportsAction.java delete mode 100644 src/main/java/org/jabref/gui/journals/ManageJournalAbbreviations.fxml delete mode 100644 src/main/java/org/jabref/gui/journals/ManageJournalsAction.java delete mode 100644 src/main/java/org/jabref/gui/keyboard/CustomizeKeyBindingAction.java delete mode 100644 src/main/java/org/jabref/gui/keyboard/KeyBindingsDialog.fxml rename src/main/java/org/jabref/gui/preferences/{ => appearance}/AppearanceTab.fxml (85%) rename src/main/java/org/jabref/gui/preferences/{AppearanceTabView.java => appearance/AppearanceTab.java} (78%) rename src/main/java/org/jabref/gui/preferences/{ => appearance}/AppearanceTabViewModel.java (98%) rename src/main/java/org/jabref/gui/preferences/{ => citationkeypattern}/CitationKeyPatternTab.fxml (84%) rename src/main/java/org/jabref/gui/preferences/{CitationKeyPatternTabView.java => citationkeypattern/CitationKeyPatternTab.java} (66%) rename src/main/java/org/jabref/gui/preferences/{ => citationkeypattern}/CitationKeyPatternTabViewModel.java (96%) rename src/main/java/org/jabref/gui/preferences/{ => entryeditor}/EntryEditorTab.fxml (89%) rename src/main/java/org/jabref/gui/preferences/{EntryEditorTabView.java => entryeditor/EntryEditorTab.java} (89%) rename src/main/java/org/jabref/gui/preferences/{ => entryeditor}/EntryEditorTabViewModel.java (98%) create mode 100644 src/main/java/org/jabref/gui/preferences/entryeditortabs/CustomEditorFieldsTab.fxml create mode 100644 src/main/java/org/jabref/gui/preferences/entryeditortabs/CustomEditorFieldsTab.java rename src/main/java/org/jabref/gui/{customizefields/CustomizeGeneralFieldsDialogViewModel.java => preferences/entryeditortabs/CustomEditorFieldsTabViewModel.java} (74%) create mode 100644 src/main/java/org/jabref/gui/preferences/exporter/ExportCustomizationTab.fxml create mode 100644 src/main/java/org/jabref/gui/preferences/exporter/ExportCustomizationTab.java rename src/main/java/org/jabref/gui/{exporter/ExportCustomizationDialogViewModel.java => preferences/exporter/ExportCustomizationTabViewModel.java} (72%) rename src/main/java/org/jabref/gui/preferences/{ => external}/ExternalTab.fxml (91%) rename src/main/java/org/jabref/gui/preferences/{ExternalTabView.java => external/ExternalTab.java} (90%) rename src/main/java/org/jabref/gui/preferences/{ => external}/ExternalTabViewModel.java (98%) rename src/main/java/org/jabref/gui/preferences/{ => file}/FileTab.fxml (91%) rename src/main/java/org/jabref/gui/preferences/{FileTabView.java => file/FileTab.java} (87%) rename src/main/java/org/jabref/gui/preferences/{ => file}/FileTabViewModel.java (97%) rename src/main/java/org/jabref/gui/preferences/{ => general}/GeneralTab.fxml (93%) rename src/main/java/org/jabref/gui/preferences/{GeneralTabView.java => general/GeneralTab.java} (93%) rename src/main/java/org/jabref/gui/preferences/{ => general}/GeneralTabViewModel.java (98%) rename src/main/java/org/jabref/gui/preferences/{ => groups}/GroupsTab.fxml (85%) rename src/main/java/org/jabref/gui/preferences/{GroupsTabView.java => groups/GroupsTab.java} (80%) rename src/main/java/org/jabref/gui/preferences/{ => groups}/GroupsTabViewModel.java (92%) create mode 100644 src/main/java/org/jabref/gui/preferences/importer/ImportCustomizationTab.fxml rename src/main/java/org/jabref/gui/{importer/ImportCustomizationDialog.java => preferences/importer/ImportCustomizationTab.java} (56%) rename src/main/java/org/jabref/gui/{importer/ImportCustomizationDialogViewModel.java => preferences/importer/ImportCustomizationTabViewModel.java} (90%) rename src/main/java/org/jabref/gui/{ => preferences}/journals/AbbreviationViewModel.java (98%) rename src/main/java/org/jabref/gui/{ => preferences}/journals/AbbreviationsFileViewModel.java (98%) rename src/main/java/org/jabref/gui/{journals/ManageJournalAbbreviations.css => preferences/journals/JournalAbbreviationsTab.css} (100%) create mode 100644 src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTab.fxml rename src/main/java/org/jabref/gui/{journals/ManageJournalAbbreviationsView.java => preferences/journals/JournalAbbreviationsTab.java} (77%) rename src/main/java/org/jabref/gui/{journals/ManageJournalAbbreviationsViewModel.java => preferences/journals/JournalAbbreviationsTabViewModel.java} (91%) rename src/main/java/org/jabref/gui/{keyboard => preferences/keybindings}/KeyBindingViewModel.java (96%) rename src/main/java/org/jabref/gui/{keyboard/KeyBindingsDialog.css => preferences/keybindings/KeyBindingsTab.css} (100%) create mode 100644 src/main/java/org/jabref/gui/preferences/keybindings/KeyBindingsTab.fxml rename src/main/java/org/jabref/gui/{keyboard/KeyBindingsDialogView.java => preferences/keybindings/KeyBindingsTab.java} (70%) rename src/main/java/org/jabref/gui/{keyboard/KeyBindingsDialogViewModel.java => preferences/keybindings/KeyBindingsTabViewModel.java} (76%) rename src/main/java/org/jabref/gui/{keyboard => preferences/keybindings}/presets/BashKeyBindingPreset.java (96%) rename src/main/java/org/jabref/gui/{keyboard => preferences/keybindings}/presets/KeyBindingPreset.java (75%) rename src/main/java/org/jabref/gui/preferences/{ => linkedfiles}/LinkedFilesTab.fxml (81%) rename src/main/java/org/jabref/gui/preferences/{LinkedFilesTabView.java => linkedfiles/LinkedFilesTab.java} (91%) rename src/main/java/org/jabref/gui/preferences/{ => linkedfiles}/LinkedFilesTabViewModel.java (97%) rename src/main/java/org/jabref/gui/preferences/{ => nameformatter}/NameFormatterItemModel.java (96%) rename src/main/java/org/jabref/gui/preferences/{ => nameformatter}/NameFormatterTab.fxml (91%) rename src/main/java/org/jabref/gui/preferences/{NameFormatterTabView.java => nameformatter/NameFormatterTab.java} (93%) rename src/main/java/org/jabref/gui/preferences/{ => nameformatter}/NameFormatterTabViewModel.java (94%) rename src/main/java/org/jabref/gui/preferences/{ => network}/NetworkTab.fxml (92%) rename src/main/java/org/jabref/gui/preferences/{NetworkTabView.java => network/NetworkTab.java} (93%) rename src/main/java/org/jabref/gui/preferences/{ => network}/NetworkTabViewModel.java (99%) rename src/main/java/org/jabref/gui/preferences/{ => preview}/PreviewTab.fxml (92%) rename src/main/java/org/jabref/gui/preferences/{PreviewTabView.java => preview/PreviewTab.java} (96%) rename src/main/java/org/jabref/gui/preferences/{ => preview}/PreviewTabViewModel.java (98%) rename src/main/java/org/jabref/gui/{ => preferences}/protectedterms/NewProtectedTermsFileDialog.java (69%) create mode 100644 src/main/java/org/jabref/gui/preferences/protectedterms/ProtectedTermsTab.fxml rename src/main/java/org/jabref/gui/{protectedterms/ManageProtectedTermsDialog.java => preferences/protectedterms/ProtectedTermsTab.java} (81%) rename src/main/java/org/jabref/gui/{protectedterms/ManageProtectedTermsViewModel.java => preferences/protectedterms/ProtectedTermsTabViewModel.java} (61%) rename src/main/java/org/jabref/gui/preferences/{ => table}/TableTab.fxml (93%) rename src/main/java/org/jabref/gui/preferences/{TableTabView.java => table/TableTab.java} (95%) rename src/main/java/org/jabref/gui/preferences/{ => table}/TableTabViewModel.java (99%) rename src/main/java/org/jabref/gui/preferences/{ => xmp}/XmpPrivacyTab.fxml (78%) rename src/main/java/org/jabref/gui/preferences/{XmpPrivacyTabView.java => xmp/XmpPrivacyTab.java} (92%) rename src/main/java/org/jabref/gui/preferences/{ => xmp}/XmpPrivacyTabViewModel.java (95%) delete mode 100644 src/main/java/org/jabref/gui/protectedterms/ManageProtectedTermsAction.java delete mode 100644 src/main/java/org/jabref/gui/protectedterms/ManageProtectedTermsDialog.fxml rename src/test/java/org/jabref/gui/journals/{ManageJournalAbbreviationsViewModelMixedAbbreviationsTest.java => JournalAbbreviationsViewModelMixedAbbreviationsTabTest.java} (97%) rename src/test/java/org/jabref/gui/journals/{ManageJournalAbbreviationsViewModelNoShortestUniqueAbbreviationsTest.java => JournalAbbreviationsViewModelNoShortestUniqueAbbreviationsTabTest.java} (97%) rename src/test/java/org/jabref/gui/journals/{ManageJournalAbbreviationsViewModelWithShortestUniqueAbbreviationsTest.java => JournalAbbreviationsViewModelWithShortestUniqueAbbreviationsTabTest.java} (97%) rename src/test/java/org/jabref/gui/keyboard/{KeyBindingsDialogViewModelTest.java => KeyBindingsTabModelTest.java} (92%) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42da6cc6765..ea2b0bf2a19 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve - The JabRef specific meta-data content in the main field such as priorities (prio1, prio2, ...) are migrated to their respective fields. They are removed from the keywords. [#6840](https://github.com/jabref/jabref/issues/6840) - We fixed an issue where groups generated from authors' last names did not include all entries of the authors' [#5833](https://github.com/JabRef/jabref/issues/5833) - The export to MS Office XML now uses the month name for the field `MonthAcessed` instead of the two digit number [#7354](https://github.com/JabRef/jabref/issues/7354) +- We included some standalone dialogs from the options menu in the main preference dialog and fixed some visual issues in the preferences dialog. [#7384](https://github.com/JabRef/jabref/pull/7384) ### Fixed diff --git a/src/main/java/org/jabref/gui/JabRefFrame.java b/src/main/java/org/jabref/gui/JabRefFrame.java index 7e412efcff5..89be3494a67 100644 --- a/src/main/java/org/jabref/gui/JabRefFrame.java +++ b/src/main/java/org/jabref/gui/JabRefFrame.java @@ -60,7 +60,6 @@ import org.jabref.gui.contentselector.ManageContentSelectorAction; import org.jabref.gui.copyfiles.CopyFilesAction; import org.jabref.gui.customentrytypes.CustomizeEntryAction; -import org.jabref.gui.customizefields.SetupGeneralFieldsAction; import org.jabref.gui.desktop.JabRefDesktop; import org.jabref.gui.dialogs.AutosaveUiManager; import org.jabref.gui.documentviewer.ShowDocumentViewerAction; @@ -75,7 +74,6 @@ import org.jabref.gui.entryeditor.PreviewSwitchAction; import org.jabref.gui.exporter.ExportCommand; import org.jabref.gui.exporter.ExportToClipboardAction; -import org.jabref.gui.exporter.ManageCustomExportsAction; import org.jabref.gui.exporter.SaveAction; import org.jabref.gui.exporter.SaveAllAction; import org.jabref.gui.exporter.SaveDatabaseAction; @@ -90,15 +88,12 @@ import org.jabref.gui.help.SearchForUpdateAction; import org.jabref.gui.importer.ImportCommand; import org.jabref.gui.importer.ImportEntriesDialog; -import org.jabref.gui.importer.ManageCustomImportsAction; import org.jabref.gui.importer.NewDatabaseAction; import org.jabref.gui.importer.NewEntryAction; import org.jabref.gui.importer.actions.OpenDatabaseAction; import org.jabref.gui.importer.fetcher.LookupIdentifierAction; import org.jabref.gui.integrity.IntegrityCheckAction; import org.jabref.gui.journals.AbbreviateAction; -import org.jabref.gui.journals.ManageJournalsAction; -import org.jabref.gui.keyboard.CustomizeKeyBindingAction; import org.jabref.gui.keyboard.KeyBinding; import org.jabref.gui.keyboard.KeyBindingRepository; import org.jabref.gui.libraryproperties.LibraryPropertiesAction; @@ -108,7 +103,6 @@ import org.jabref.gui.metadata.PreambleEditor; import org.jabref.gui.preferences.ShowPreferencesAction; import org.jabref.gui.preview.CopyCitationAction; -import org.jabref.gui.protectedterms.ManageProtectedTermsAction; import org.jabref.gui.push.PushToApplicationAction; import org.jabref.gui.push.PushToApplicationsManager; import org.jabref.gui.search.GlobalSearchBar; @@ -851,15 +845,6 @@ private MenuBar createMenu() { new SeparatorMenuItem(), - factory.createMenuItem(StandardActions.SETUP_GENERAL_FIELDS, new SetupGeneralFieldsAction()), - factory.createMenuItem(StandardActions.MANAGE_CUSTOM_IMPORTS, new ManageCustomImportsAction()), - factory.createMenuItem(StandardActions.MANAGE_CUSTOM_EXPORTS, new ManageCustomExportsAction()), - factory.createMenuItem(StandardActions.MANAGE_JOURNALS, new ManageJournalsAction()), - factory.createMenuItem(StandardActions.CUSTOMIZE_KEYBINDING, new CustomizeKeyBindingAction()), - factory.createMenuItem(StandardActions.MANAGE_PROTECTED_TERMS, new ManageProtectedTermsAction()), - - new SeparatorMenuItem(), - factory.createMenuItem(StandardActions.MANAGE_CONTENT_SELECTORS, new ManageContentSelectorAction(this, stateManager)), factory.createMenuItem(StandardActions.CUSTOMIZE_ENTRY_TYPES, new CustomizeEntryAction(stateManager, Globals.entryTypesManager)) ); diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanel.java b/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanel.java index ac61606744c..4d004e980c3 100644 --- a/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanel.java +++ b/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanel.java @@ -2,6 +2,8 @@ import java.util.Collection; +import javax.inject.Inject; + import javafx.beans.property.ListProperty; import javafx.beans.property.ObjectProperty; import javafx.fxml.FXML; @@ -27,16 +29,16 @@ public class CitationKeyPatternPanel extends TableView patternColumn; @FXML public TableColumn actionsColumn; + @Inject private PreferencesService preferences; + private CitationKeyPatternPanelViewModel viewModel; private long lastKeyPressTime; private String tableSearchTerm; - public CitationKeyPatternPanel(PreferencesService preferences, Collection entryTypeList, AbstractCitationKeyPattern keyPattern) { + public CitationKeyPatternPanel() { super(); - viewModel = new CitationKeyPatternPanelViewModel(preferences, entryTypeList, keyPattern); - ViewLoader.view(this) .root(this) .load(); @@ -44,6 +46,8 @@ public CitationKeyPatternPanel(PreferencesService preferences, Collection entryTypeList, AbstractCitationKeyPattern keyPattern) { + viewModel.setValues(entryTypeList, keyPattern); } public void resetAll() { diff --git a/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanelViewModel.java b/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanelViewModel.java index fa3a1978b29..95416561b23 100644 --- a/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanelViewModel.java +++ b/src/main/java/org/jabref/gui/commonfxcontrols/CitationKeyPatternPanelViewModel.java @@ -36,17 +36,14 @@ public class CitationKeyPatternPanelViewModel { private final ListProperty patternListProperty = new SimpleListProperty<>(); private final ObjectProperty defaultItemProperty = new SimpleObjectProperty<>(); - private final AbstractCitationKeyPattern initialKeyPattern; - private final Collection bibEntryTypeList; + private final PreferencesService preferences; - public CitationKeyPatternPanelViewModel(PreferencesService preferences, Collection entryTypeList, AbstractCitationKeyPattern initialKeyPattern) { + public CitationKeyPatternPanelViewModel(PreferencesService preferences) { this.preferences = preferences; - this.bibEntryTypeList = entryTypeList; - this.initialKeyPattern = initialKeyPattern; } - public void setValues() { + public void setValues(Collection entryTypeList, AbstractCitationKeyPattern initialKeyPattern) { String defaultPattern; if ((initialKeyPattern.getDefaultValue() == null) || initialKeyPattern.getDefaultValue().isEmpty()) { defaultPattern = ""; @@ -58,17 +55,17 @@ public void setValues() { patternListProperty.setValue(FXCollections.observableArrayList()); patternListProperty.add(defaultItemProperty.getValue()); - bibEntryTypeList.stream() - .map(BibEntryType::getType) - .forEach(entryType -> { - String pattern; - if (initialKeyPattern.isDefaultValue(entryType)) { - pattern = ""; - } else { - pattern = initialKeyPattern.getPatterns().get(entryType).get(0); - } - patternListProperty.add(new CitationKeyPatternPanelItemModel(entryType, pattern)); - }); + entryTypeList.stream() + .map(BibEntryType::getType) + .forEach(entryType -> { + String pattern; + if (initialKeyPattern.isDefaultValue(entryType)) { + pattern = ""; + } else { + pattern = initialKeyPattern.getPatterns().get(entryType).get(0); + } + patternListProperty.add(new CitationKeyPatternPanelItemModel(entryType, pattern)); + }); } public void setItemToDefaultPattern(CitationKeyPatternPanelItemModel item) { diff --git a/src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialog.fxml b/src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialog.fxml deleted file mode 100644 index fe006e915c4..00000000000 --- a/src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialog.fxml +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - - - - - - -