From 5de0fbe8c595a6e09c050dc479d0ad6c150ecfce Mon Sep 17 00:00:00 2001
From: David Stark <david@jdavidstark.com>
Date: Wed, 29 Jun 2022 19:15:50 -0500
Subject: [PATCH] Update
 society-of-biblical-literature-fullnote-bibliography.csl (#5913)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

SBL style routinely wants a comma after an abbreviation-based citation (facilitated via annote) when the locator is sub-verbo. Other situations (sections, pages) sometimes (or often) don't include a comma.

* Update society-of-biblical-literature-fullnote-bibliography.csl

Adds a way to disambiguate electronic from print sources, which is necessary to be able to store DOIs for use by some styles but not output them for print sources in SBL style (since the style uses them only for electronic sources).

Omits a comma after the dictionary title or abbreviation in first references per SBLHS2.

 Corrects support for conference papers per SBLHS2 §6.3.8.

Simplifies the DOI, URL coordination sections per [this comment](https://github.com/citation-style-language/styles/commit/0e6c74f0676a8dfca357f03a5fe886e0cced4fac#r68836799).
---
 ...lical-literature-fullnote-bibliography.csl | 68 +++++++++++++------
 1 file changed, 46 insertions(+), 22 deletions(-)

diff --git a/society-of-biblical-literature-fullnote-bibliography.csl b/society-of-biblical-literature-fullnote-bibliography.csl
index 3078db2f8e0f..99eaa04018a0 100644
--- a/society-of-biblical-literature-fullnote-bibliography.csl
+++ b/society-of-biblical-literature-fullnote-bibliography.csl
@@ -33,7 +33,7 @@
     <category citation-format="note"/>
     <category field="theology"/>
     <summary>Society of Biblical Literature format with full notes and bibliography</summary>
-    <updated>2022-05-27T18:39:17+00:00</updated>
+    <updated>2022-06-29T13:58:51+00:00</updated>
     <rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
   </info>
   <locale xml:lang="en-US">
@@ -113,11 +113,11 @@
     <choose>
       <if type="bill book chapter graphic legal_case legislation motion_picture paper-conference report song" match="any">
         <group delimiter=", ">
-          <text macro="editor-translator-verb-short-comma"/>
           <names variable="container-author">
             <label form="verb-short" suffix=" "/>
             <name and="text" delimiter=", "/>
           </names>
+          <text macro="editor-translator-verb-short-comma"/>
         </group>
       </if>
     </choose>
@@ -382,7 +382,7 @@
         </choose>
       </else-if>
       <else>
-        <text variable="title" form="short" quotes="true" text-case="title"/>
+        <text variable="title" quotes="true" text-case="title"/>
       </else>
     </choose>
   </macro>
@@ -675,7 +675,16 @@
     </choose>
   </macro>
   <macro name="event-note">
-    <text variable="event"/>
+    <!-- Support citation of unpublished conference presentations per SBLHS2 §6.3.8. -->
+    <choose>
+      <if type="speech" match="any">
+        <group delimiter=" ">
+          <text variable="genre"/>
+          <text term="presented at" suffix=" "/>
+        </group>
+      </if>
+    </choose>
+    <text variable="event" suffix=","/>
   </macro>
   <macro name="event">
     <group>
@@ -791,7 +800,15 @@
                   <else>
                     <group delimiter=" ">
                       <label variable="locator" form="short"/>
-                      <text variable="locator"/>
+                      <!-- Adds quotes around the locator when the type is sub-verbo per https://sblhs2.com/2017/03/30/citing-reference-works-2-lexica/ -->
+                      <choose>
+                        <if locator="sub-verbo">
+                          <text variable="locator" quotes="true"/>
+                        </if>
+                        <else>
+                          <text variable="locator"/>
+                        </else>
+                      </choose>
                     </group>
                   </else>
                 </choose>
@@ -841,9 +858,9 @@
       </else-if>
       <else-if type="entry-dictionary entry-encyclopedia" match="any">
         <choose>
-          <if position="first" variable="volume" match="all">
+          <if position="first" match="all">
             <text macro="point-locators-subsequent" prefix=" "/>
-            <!--SBL 6.3.6 prefers space in first entry before vol info.-->
+            <!-- Per SBLHS2 §6.3.6, the first reference will, by definition have the dictionary title or abbreviation preceding the locators, volume number included. No comma should appear after the title or abbreviation and before the locators. -->
           </if>
           <else>
             <text macro="point-locators-subsequent" prefix=", "/>
@@ -926,11 +943,10 @@
                   <text macro="publisher"/>
                   <choose>
                     <if variable="title" match="none"/>
-                    <else-if type="thesis speech" match="any">
+                    <else-if type="thesis" match="any">
                       <text variable="genre"/>
                     </else-if>
                   </choose>
-                  <text macro="event"/>
                 </group>
                 <text macro="issued" prefix=", "/>
               </group>
@@ -991,12 +1007,15 @@
           <text macro="archive-note"/>
         </else-if>
       </choose>
+      <!-- SBL style uses DOIs and URLs when the resource is electronic. SBLHS2 §§ 6.1.6, 6.2.25, 6.3.10, 6.4.13&#8211;14. If a resource has physical dimensions, however, it is not electronic. So, DOI or URL output should be bypassed. -->
       <choose>
-        <if variable="DOI">
-          <text variable="DOI" prefix="https://doi.org/"/>
-        </if>
+        <if variable="dimensions"/>
         <else>
-          <text variable="URL"/>
+          <!-- Per SBLHS2 §6.3.10, allows either DOI or URL or both to be included. -->
+          <group delimiter=", ">
+            <text variable="DOI" prefix="https://doi.org/"/>
+            <text variable="URL"/>
+          </group>
         </else>
       </choose>
     </group>
@@ -1011,12 +1030,15 @@
           <text macro="archive"/>
         </else-if>
       </choose>
+      <!-- SBL style uses DOIs and URLs when the resource is electronic. SBLHS2 §§6.1.6, 6.2.25, 6.3.10, 6.4.13&#8211;14. If a resource has physical dimensions, however, it is not electronic. So, DOI or URL output should be bypassed. -->
       <choose>
-        <if variable="DOI">
-          <text variable="DOI" prefix="https://doi.org/"/>
-        </if>
+        <if variable="dimensions"/>
         <else>
-          <text variable="URL"/>
+          <!-- Per SBLHS2 §6.3.10, allows either DOI or URL or both to be included. -->
+          <group delimiter=", ">
+            <text variable="DOI" prefix="https://doi.org/"/>
+            <text variable="URL"/>
+          </group>
         </else>
       </choose>
     </group>
@@ -1072,14 +1094,16 @@
         <!-- Support custom citations via the annote variable. For discussion, see https://forums.zotero.org/discussion/comment/317370 -->
         <if variable="annote">
           <choose>
-            <if locator="section">
-              <group delimiter=" ">
+            <!-- For situations like citation of lexica per https://sblhs2.com/2017/03/30/citing-reference-works-2-lexica/. -->
+            <if locator="sub-verbo">
+              <group delimiter=", ">
                 <text variable="annote"/>
                 <text macro="point-locators-subsequent"/>
               </group>
             </if>
+            <!-- For situations like citation of collections like (M)OTP per https://sblhs2.com/2017/06/08/citing-text-collections-3-otp/ and https://sblhs2.com/2017/06/22/citing-text-collections-3-motp/. -->
             <else>
-              <group delimiter=", ">
+              <group delimiter=" ">
                 <text variable="annote"/>
                 <text macro="point-locators-subsequent"/>
               </group>
@@ -1115,6 +1139,7 @@
           <group delimiter=", ">
             <text macro="contributors-note"/>
             <text macro="title-note"/>
+            <text macro="description-note"/>
             <text macro="secondary-contributors-note"/>
             <text macro="container-title-note"/>
             <text macro="container-contributors-note"/>
@@ -1138,7 +1163,6 @@
           <text macro="locators-newspaper" prefix=", "/>
           <text macro="point-locators"/>
           <text macro="access-note" prefix=", "/>
-          <text macro="description-note" prefix=", "/>
         </else>
       </choose>
     </layout>
@@ -1168,6 +1192,7 @@
           <group delimiter=". ">
             <text macro="contributors"/>
             <text macro="title"/>
+            <text macro="description"/>
             <text macro="secondary-contributors"/>
             <text macro="container-title"/>
             <text macro="container-contributors"/>
@@ -1188,7 +1213,6 @@
           <text macro="locators-newspaper" prefix=", "/>
           <text macro="locators-journal"/>
           <text macro="access" prefix=". "/>
-          <text macro="description" prefix=". "/>
         </else>
       </choose>
     </layout>