Skip to content

Commit

Permalink
Reorder checklist in PR template and add "good commit message"
Browse files Browse the repository at this point in the history
  • Loading branch information
@koppor
koppor authored Feb 21, 2018
1 parent 667525a commit d6fc974
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@

----

- [ ] Change in CHANGELOG.md described
- [ ] Tests created for changes
- [ ] Screenshots added (for bigger UI changes)
- [ ] Manually tested changed features in running JabRef
- [ ] Screenshots added in PR description (for bigger UI changes)
- [ ] Tests created for changes
- [ ] Change in CHANGELOG.md described
- [ ] Ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message)
- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)

1 comment on commit d6fc974

@Siedlerchr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still consider changelog as more important, so I would prefer to have it on top.

Please sign in to comment.