Pressing Escape does not close entry editor

[tobiasdiez]

No description provided.

[Siedlerchr]

Could be related to my last changes, we probably just need to add a Check for the escape key

[koppor]

Somehow related:

• Ctrl+S does not work. Neither when focused in the entry nor when the entry table is focused.
• Star for modified database not shown if I change something in the entry editor

[Siedlerchr]

This does not work when you are in an entry editor field.

[Siedlerchr]

Escape now works. For save, we first need to create a save action in the entry editor. I will create a follow up PR

[tobiasdiez]

The save command shouldn't be handled by the entry editor but by a higher instance (probably JabRefMain).

[Siedlerchr]

Yes, but the problem is that it is not that easy to filter out the command from the JFX panel, because we would need to map between awt keyEvents and javafx keyEvents/KeyCombination. Unfortuately there is no easy way to do this.
So I would suggest creating a save action analogous to the close action in EntryEditor/ setupKeyBindings

[tobiasdiez]

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!

[koppor]

Since two years, this does not work. At #11190 (comment), we decided to stick with Ctrl+E to open/close the entry editor.