Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnifier changes colors wrong #3870

Closed
koppor opened this issue Mar 21, 2018 · 4 comments
Closed

Magnifier changes colors wrong #3870

koppor opened this issue Mar 21, 2018 · 4 comments
Labels

Comments

@koppor
Copy link
Member

koppor commented Mar 21, 2018

JabRef offers two search modes: normal search and the grammar based ("advanced") search. See https://help.jabref.org/en/Search#search-modes.

In JabRef 3.6, the initial search was the normal search. This changed in JabRef 3.7 somehow. This seems to be wrong.

Action points:

  1. Dig into the change made between JabRef 3.6 and 3.7
  2. Find out whether the change is right or wrong. Current assumption: It was wrong
  3. Take appropriate action.

Refs #3535 and the fix #3708

@koppor koppor added the ui label Mar 21, 2018
@lenhard
Copy link
Member

lenhard commented Mar 21, 2018

Instead of 1. and 2., can't we just go to 3.? Wouldn't the solution be to switch the coloring (i.e. initially purple and then cyan)? That would be a two-liner I can easily do once you tell me that the assumption is correct.

In adition, I'd like to mention the fact that the whole coloring feature is gone (again) in the maintable-beta branch. If you want it to be preserved, you'll probably need to do some lobbying there.

@koppor
Copy link
Member Author

koppor commented Mar 21, 2018

If 3 is easily possible, please go ahead.

@lenhard
Copy link
Member

lenhard commented Mar 21, 2018

Et voilà: #3871

@tobiasdiez
Copy link
Member

I think the underlying problem is that simple terms like "test" are interpreted as grammar-based searches. This is also the reason why the tooltip shows "This search contains entries" twice in the tooltip (at least on maintable-beta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants