Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify month field formatting in test bib files #5116

Closed
Siedlerchr opened this issue Jul 11, 2019 · 4 comments
Closed

Unify month field formatting in test bib files #5116

Siedlerchr opened this issue Jul 11, 2019 · 4 comments
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: code-quality Issues related to code or architecture decisions

Comments

@Siedlerchr
Copy link
Member

In several bib files we have not a unique formatting for the month:

Example:
Some bib files used for testing have different formats for the months.
This should be made consistent across all files

correct;

  number    = {1},
  pages     = {55--68},
  month     = oct,

other looks like

  number    = {1},
  pages     = {55--68},
  month     = #oct#,

other looks like

  number    = {1},
  pages     = {55--68},
  month     =  {#oct#},
@Siedlerchr Siedlerchr added type: code-quality Issues related to code or architecture decisions good first issue An issue intended for project-newcomers. Varies in difficulty. labels Jul 11, 2019
@vitorcime
Copy link

Do you know where can I find this bibs files ?

@koppor
Copy link
Member

koppor commented Jul 13, 2019

@vitorcime Use your IDE's search capability. Ctrl+Shift+F in IntelliJ.

@koppor
Copy link
Member

koppor commented Jul 13, 2019

Note that # is used to render a BibTeX string (see http://help.jabref.org/en/EntryEditor#field-consistency-checking). That means, the entry editor displays #oct# when the BibTeX field is month = oct. Thus, oct is correct. #oct# and {#oct#} are wrong. They are a result of a wrong implementation somewhere in JabRef. We guess that it is at the entry fetchers or converters (RIS for instance).

@PorcelainMouse
Copy link

I think this is related to another issue. The "cleanup entries" implements a "normalize" option on the month field, but converts to abbreviated month, which is not supported by python-bibtexparser (by default). Also, JabRef writes this field as an integer, not a string, when set from the GUI pull-down field. So, the code is is not consistent, either.

Is this the right issue? Or, should I open another one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

No branches or pull requests

4 participants