Copy... -> Export to clipboard Dialog has no icon

[Siedlerchr]

Select an entry in the main table

1. Right click -> Copy... -> Export to Clipboard

See that there is no icon. This results in the standard java icon shown in the task bar on windows

5.1 master

[MootezSaaD]

Hello, I would like to inquire if I could contribute by fixing this issue.

[Siedlerchr]

@MootezSaaD Sure. The dialog should be called somewhere in org.jabref.gui.exporter.ExportToClipboardAction

[MootezSaaD]

Hello,
Sorry for the delay, I have tried to convert the ExportToClipboard to mvvm-pattern, this is the dialog

What I have done is I created ExportToClipboardViewModel and ExportToClipboardDialogView and ExportToClipboardAction now calls ExportToClipboardDialogView .
Is it fine to make a draft PR ?

[Siedlerchr]

@MootezSaaD Oh wow, well, that would be a solution, but I fear that you have "overengineered" in this case. Maybe I also did not specify it better, but if you look into the JabRefDialogService class, there the dialog is created by using the standard ChoicedDialog component.

I think the solution would be just a one liner as in the ProgressDialog:
((Stage) progressDialog.getDialogPane().getScene().getWindow()).getIcons().add(IconTheme.getJabRefImageFX());

[MootezSaaD]

Oh then that settles it, thank you @Siedlerchr

[Siedlerchr]

See your other work not as wasted, but as a good training that enables you a good understanding of the Gui in jabref and hopefully you are interested in fixing other issues as well.

[MootezSaaD]

Absolutely!
Thank you again for the assistance