Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unselect entries in the main table and opacity of disabled icon-buttons #7195

Closed
k3KAW8Pnf7mkmdSMPHz27 opened this issue Dec 15, 2020 · 4 comments · Fixed by #7655
Closed

Comments

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.

  1. At the moment you can't unselect bib entries in the main table. This is perhaps a useless feature but it is part of my "default behaviour". If I am editing a bib entry in a small library, and I want to close the entry tab I click on an empty row in the main table, and I expect the bib entry to be unselected and the entry tab to hide (since there is no longer a selected entry to edit). Am I the only one that repeatedly does this ? 😬
  2. On a related note, should disabled icon-buttons change opacity, e.g., if no bib entry is selected.

Additional context
Regarding disabled icon-buttons,

.icon-button:disabled {
    -fx-opacity: 0.4;
}

Looks good to me.
Skärmavbild 2020-12-15 kl  09 12 29
vs
Skärmavbild 2020-12-15 kl  09 12 33

@tobiasdiez
Copy link
Member

I think both ideas are good. Would you mind creating PRs for them? (we already have ActionHelper.needsEntriesSelected so this should be straigthforward)

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

Great!
I'll split it over two PRs. One dealing with the opacity/disabled, which should be finished quicker, and one trying to figure out when it is reasonable to "lose" a selection.

@JavuesZhang
Copy link
Contributor

Hi! Does this issue still accept pull request?

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

@JavuesZhang, if it is still a problem in the latest version, yes. I unfortunately haven't had time to look at the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants