-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table of formatters #920
Comments
I have just removed a duplicated formatter |
|
What is related to this PR is that we should have a clear QA what is required to include a new formatter.
Therefore, I propose to remove/improve the following formatters:
Comments and changes welcome! |
@JabRef/developers As this is a blocker for v3.3 (especially the keys for avoiding migrations later on) all of you should have a look. |
@stefan-kolb Have your tried the HTML/Unicode to Latex (or back, layout formatters) converters recently? :-) I'd say it is probably the best/most complete open source converter suite available (beaten only by Latex when it comes to Latex to Unicode...). The unit converter handles all SI units and quite a lot of derived ones. Would be a shame to remove it as it provides automatic proper formatting for quite a lot of cases. Case keeper is very EE focused at the moment (since I wrote it and probably has been the only one adding words and abbreviations to it). Since IEEE now provide quite OK bracing, the need is reduced for it. Still, I'd say keep and later make it configurable for people to add their own words. To automatically be able to add braces to the correct words (as opposed to all capital letters) is far superior. Even after running some case converter. The authors formatter should use one of the two already existing, far superior, methods to format names. Author list or even better the one in bst. In general, usability is quite user dependent. There are a few for matters I will never ever use and a few which you have rendered useless that I use regularly... |
@oscargus Like I said I'm open for suggestions. I'd just took a look from a customers point of view at first. Haven't evaluated the code of each Formatter. |
So what about UppercaseChanger and TrimFormatter at least? |
I think the UppercaseChanger can be removed. The only application I see is that this formatter is used in the generation of cite-keys, where it might make sense (but again, then this is not a Formatter but a LayoutFormatter). Regarding the TrimFormatter So far we had the "don't change the contents of the fields until asked to do so"-policy. On the other hand, I find it reasonable to always trim the field contents. |
My following list is based on Simon's. Additionally, I also did some sorting and also did add classnames I like the CamelCase key names, therefore I put CamelCase there. Regarding the name: I think, it reads strange, if we have a name with two words and the first word is sometimes capitalized and sometimes not. Therefore, I write everything in lower case. Questions: Regarding FreezeTerms and UnfreezeTerms: This are no opposite formatters. Therefore, I included "UnfreezeWords". Maybe "UnfreezeAllWords" would be better? I really vote for keeping AuthorsFormatter as it is a different thing than AuthorList and is more powerful. See #950. UpperCaseChanger: We can convert them to a LayoutFormatter. TimFormatter: +1 for always trimming during writing an entry. Authors related
Date related
Page related
Casing related
LaTeX conversion
Radical formatters
|
We have to be sure, what |
I'm quite satisfied with the proposals of Simon and Olly.
|
|
This issue summarizes all the available formatters.
The aim is to improve their names and descriptions.
I think the most practicable way is to directly edit this post with the new proposed version.
Remarks:
The text was updated successfully, but these errors were encountered: