Global Search: Clicking an entry in the search window should lead to a selection in the corresponding library

[koppor]

Issues left:

• Preview in dark theme when no search results is still "white"
  
• Location of the pin to top button
  
• When clicking an entry in the search window, it should be marked in the corresponding library (JabRef should focus the library and then select the item in the main table)
• Search dialog has to retain size (-> store size in preferences)
• Debatable: If the columns such as status or relevant should NOT be shown, because one could theoretically change the value of them in the search window...

Originally posted by @Siedlerchr in #8054 (comment)

[DanielS01ss]

Hi
I would love to work on this task!

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[KunalBainsla]

Hi there.
I would like to take this task.

[JawadTUE]

Hi, can I be assigned to this issue? I would like to work on it for a university project.

[ThiloteE]

How to reproduce:

[ThiloteE]

@KunalBainsla are you still on it?
@JawadTUE, I would say if KunalBainsla will not respond within a day, go for it. Thank you :-)

[JawadTUE]

We started working on it and managed to fix 2 of the sub-issues. We will open a (draft) pull request soon.

[koppor]

Since some issues are independent, you can create branch per issue and submit a PR for each of that branch. This enables faster reviewing and getting the fixes into JabRef's main code.

[koppor]

Not all PRs are mreged yet, thus I keep it open.

[calixtus]

Oops, was marked as "fixes" in the other pr. Sry.

[koppor]

Item 2 and 3 not solved yet. Therefore, reopened.

[Siedlerchr]

Part 2 is fixed. Part 3 not yet

[derronli]

I'd like to give this a try.

I began looking at the issue, and was thinking the solution lies in GlobalSearchResultDialogue.java (Below)

Was wondering if anyone could point me in the right direction.

[calixtus]

I believe you need to inject the frame as a librarytabcontainer the search dialog and use some sort of a select entry method in the librarytab class.

[Siedlerchr]

Another idea would to be to set the selectedEntries in the statemanager as we only have the database contextes in the SearchResultsTableDataModel

[derronli]

Sorry to bother, I've been working on this for the past week. I've read the documentation on Javafx MVVM pattern and I think I have a high level understanding of the UI. I'm struggling to understand using the stateManager and the structure of selections. In GlobalSearchResultDialog.java I've tried using the setSelectedEntries method of the stateManager in a few different ways with no success.
Could I ask for further explanation on how to continue or an existing example on selection handling? Thank you!