Ignore submodule changes (for normal devs) #10754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added
the
status: ready-for-review
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
reviewed
Jan 8, 2024
| path = buildres/abbrv.jabref.org | ||
| url = https://github.com/JabRef/abbrv.jabref.org.git | ||
| [submodule "buildres/csl-styles"] |
There was a problem hiding this comment.
The path itself did not change. The name of the submodule was NOT reflecting the actual path. Since the name is an identifier for humans, I thought, briefty is better. I could also fix the path name, but was afraid that af an update of the path in the future the name would not be updated and thus inconsistent again.
Siedlerchr
approved these changes
Jan 8, 2024
Siedlerchr
added a commit
that referenced
this pull request
Jan 12, 2024
* upstream/main: (25 commits) Remove remainging "testLogging" (#10769) Reuse JUnit 5.7's @DisabledIfEnvironmentVariable (#10768) Refactored LibraryTab (#10732) Fix annotation (#10766) Add initial .git-blame-ignore-revs (#10765) Streamline test output (#10762) Fix NPE when opening and re-opening a library (#10763) Changed default status of 'Automatically open folder of attached files' (#10748) Implement test cases for search (#10193) Add cites field to bib entries for citation relation (#10752) Ignore submodule changes (for normal devs) (#10754) Fix line endings Bump lycheeverse/lychee-action from 1.8.0 to 1.9.0 (#10760) Bump appleboy/ssh-action from 1.0.2 to 1.0.3 (#10761) Bump org.apache.lucene:lucene-core from 9.9.0 to 9.9.1 (#10759) Bump org.openrewrite.rewrite from 6.5.4 to 6.6.3 (#10758) Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (#10755) Bump org.jsoup:jsoup from 1.16.2 to 1.17.2 (#10756) Bump org.mockito:mockito-core from 5.7.0 to 5.8.0 (#10757) Remove abstract ...
|
Works: #10785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via https://stackoverflow.com/a/12527608/873282, I found a solution for our "dirty" sub modules.
The GitHub workflow update is a "wild guess". I would say: Merge and fix the workflows if they don't work.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)