From 070e6870f78c600868b978ca263fc4ffbcd78807 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Sun, 21 Apr 2024 08:15:52 +0530
Subject: [PATCH 01/28] Update PreviewTab.fxml

---
 src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml
index 0b31d99de58..2e7c2b27126 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml
@@ -22,6 +22,7 @@
     <CheckBox fx:id="showAsTabCheckBox" text="%Show preview as a tab in entry editor"/>
     <CheckBox fx:id="showPreviewTooltipCheckBox" text="Show preview in entry table tooltip"/>
     <HBox spacing="4.0">
+        <Button fx:id="bstFileButton" text="Select BST File" onAction="#selectBstFile" />
         <VBox spacing="4.0" HBox.hgrow="ALWAYS">
             <Label text="%Available" styleClass="sectionHeader"/>
             <CustomTextField fx:id="searchBox" promptText="%Filter" VBox.vgrow="NEVER" prefHeight="20.0"/>

From dbfc138a59ef402c527eb39769ad22e73a345e04 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Sun, 21 Apr 2024 08:31:56 +0530
Subject: [PATCH 02/28] Update PreviewTab.java

---
 .../gui/preferences/preview/PreviewTab.java   | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index 933edb523e0..5a0c87926f7 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -1,10 +1,13 @@
 package org.jabref.gui.preferences.preview;
 
+import java.io.File;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
 
 import javafx.application.Platform;
 import javafx.beans.property.ListProperty;
+import javafx.event.ActionEvent;
 import javafx.fxml.FXML;
 import javafx.scene.control.Button;
 import javafx.scene.control.CheckBox;
@@ -18,6 +21,7 @@
 import javafx.scene.input.KeyEvent;
 import javafx.scene.input.MouseEvent;
 import javafx.scene.input.TransferMode;
+import javafx.stage.FileChooser;
 
 import org.jabref.gui.Globals;
 import org.jabref.gui.StateManager;
@@ -32,6 +36,7 @@
 import org.jabref.gui.util.BindingsHelper;
 import org.jabref.gui.util.IconValidationDecorator;
 import org.jabref.gui.util.ViewModelListCellFactory;
+import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.preview.PreviewLayout;
 import org.jabref.logic.util.TestEntry;
@@ -104,6 +109,21 @@ public String getTabName() {
         return Localization.lang("Entry preview");
     }
 
+    @FXML
+    private void selectBstFile(ActionEvent event) {
+    FileChooser fileChooser = new FileChooser();
+    fileChooser.setTitle("Select BST File");
+    fileChooser.getExtensionFilters().add(new FileChooser.ExtensionFilter("BST Files", "*.bst"));
+
+    File selectedFile = fileChooser.showOpenDialog(null);
+    if (selectedFile != null) {
+        String filePath = selectedFile.getAbsolutePath();
+        BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(Path.of(filePath));
+        viewModel.availableListProperty().add(bstPreviewLayout);
+        previewViewer.setEntry(TestEntry.getTestEntry());
+    }
+}
+    
     public void initialize() {
         this.viewModel = new PreviewTabViewModel(dialogService, preferencesService.getPreviewPreferences(), taskExecutor, stateManager);
         lastKeyPressTime = System.currentTimeMillis();

From 293b77730cd0fc4bd3f13dd1fed02cf1cf8cc7df Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Sun, 21 Apr 2024 08:35:11 +0530
Subject: [PATCH 03/28] Update PreviewTabViewModel.java

---
 .../jabref/gui/preferences/preview/PreviewTabViewModel.java | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index d315d65997d..e36ad24b39d 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -157,8 +157,10 @@ public void setPreviewLayout(PreviewLayout selectedLayout) {
             sourceTextProperty.setValue(layout.getText().replace("__NEWLINE__", "\n"));
             selectedIsEditableProperty.setValue(true);
         } else {
-            sourceTextProperty.setValue(((CitationStylePreviewLayout) selectedLayout).getSource());
-            selectedIsEditableProperty.setValue(false);
+            if (selectedLayout instanceof CitationStylePreviewLayout) {
+                sourceTextProperty.setValue(((CitationStylePreviewLayout) selectedLayout).getSource());
+                selectedIsEditableProperty.setValue(false);
+            }
         }
     }
 

From a46bee8924e7054389afdc8e9cc4c800305a3372 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Sun, 21 Apr 2024 22:26:38 +0530
Subject: [PATCH 04/28] fix undeclared variable

---
 src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index 5a0c87926f7..dd01aff7951 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -120,7 +120,6 @@ private void selectBstFile(ActionEvent event) {
         String filePath = selectedFile.getAbsolutePath();
         BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(Path.of(filePath));
         viewModel.availableListProperty().add(bstPreviewLayout);
-        previewViewer.setEntry(TestEntry.getTestEntry());
     }
 }
     

From 0126f39a8342ecadc8bf1584aa51c693bf45ea72 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Sun, 21 Apr 2024 22:40:25 +0530
Subject: [PATCH 05/28] Update CHANGELOG.md for committed changes for issue
 11102

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3c2d37b3e28..945a484f1e0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added tooltip on main table cells that shows cell content or cell content and entry preview if set in preferences. [10925](https://github.com/JabRef/jabref/issues/10925)
 - We added the ability to add a keyword/crossref when typing the separator character (e.g., comma) in the keywords/crossref fields. [#11178](https://github.com/JabRef/jabref/issues/11178)
 - We added an exporter and improved the importer for Endnote XML format. [#11137](https://github.com/JabRef/jabref/issues/11137)
+- We added a button in gui to give users an easy option to select and add local bst files to available styles in preview layout list. [#11102](https://github.com/JabRef/jabref/issues/11102) 
 
 ### Changed
 

From 5a5be03e8d5dcd0f4c2781aa4bc92a08a79399ab Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Sun, 21 Apr 2024 23:11:19 +0530
Subject: [PATCH 06/28] Update CHANGELOG.md for fixing markdown spacing error

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 945a484f1e0..5681827b24f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,7 +18,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added tooltip on main table cells that shows cell content or cell content and entry preview if set in preferences. [10925](https://github.com/JabRef/jabref/issues/10925)
 - We added the ability to add a keyword/crossref when typing the separator character (e.g., comma) in the keywords/crossref fields. [#11178](https://github.com/JabRef/jabref/issues/11178)
 - We added an exporter and improved the importer for Endnote XML format. [#11137](https://github.com/JabRef/jabref/issues/11137)
-- We added a button in gui to give users an easy option to select and add local bst files to available styles in preview layout list. [#11102](https://github.com/JabRef/jabref/issues/11102) 
+- We added a button in gui to give users an easy option to select and add local bst files to available styles in preview layout list. [#11102](https://github.com/JabRef/jabref/issues/11102)
 
 ### Changed
 

From 589eb1c33cd85a506885ffa2b7b6492aa7e6737a Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Mon, 22 Apr 2024 00:24:18 +0530
Subject: [PATCH 07/28] build.gradle openrewrite

---
 build.gradle | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/build.gradle b/build.gradle
index a0d3ede962a..4eb5718efa3 100644
--- a/build.gradle
+++ b/build.gradle
@@ -590,9 +590,7 @@ checkstyle {
 }
 
 rewrite {
-    activeRecipe(
-        'org.jabref.config.rewrite.cleanup'
-    )
+    activeRecipes = ['org.jabref.config.rewrite.cleanup','org.openrewrite.staticanalysis.InstanceOfPatternMatch']
     exclusion (
         "build.gradle",
         "buildSrc/build.gradle",

From cdabc1ff306cb98c14a8a2d58bae1539ef835584 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Mon, 22 Apr 2024 00:36:44 +0530
Subject: [PATCH 08/28] fix gradle errors

---
 build.gradle | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/build.gradle b/build.gradle
index 4eb5718efa3..a0d3ede962a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -590,7 +590,9 @@ checkstyle {
 }
 
 rewrite {
-    activeRecipes = ['org.jabref.config.rewrite.cleanup','org.openrewrite.staticanalysis.InstanceOfPatternMatch']
+    activeRecipe(
+        'org.jabref.config.rewrite.cleanup'
+    )
     exclusion (
         "build.gradle",
         "buildSrc/build.gradle",

From a54ecc27ed5328945f0225a53e369563363c1d44 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Mon, 22 Apr 2024 11:45:46 +0530
Subject: [PATCH 09/28] Update PreviewTabViewModel.java for bstlayout
 getsource() case handling

---
 .../gui/preferences/preview/PreviewTabViewModel.java   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index e36ad24b39d..6e296591459 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -153,11 +153,13 @@ public void setPreviewLayout(PreviewLayout selectedLayout) {
                     Localization.lang("Parsing error") + ": " + Localization.lang("illegal backslash expression"), exception);
         }
 
-        if (selectedLayout instanceof TextBasedPreviewLayout layout) {
-            sourceTextProperty.setValue(layout.getText().replace("__NEWLINE__", "\n"));
-            selectedIsEditableProperty.setValue(true);
+        if (selectedLayout instanceof BstPreviewLayout) {
+            // needs implementation of getSource() for bst layout otherwise throwing runtime error.
         } else {
-            if (selectedLayout instanceof CitationStylePreviewLayout) {
+            if (selectedLayout instanceof TextBasedPreviewLayout layout) {
+                sourceTextProperty.setValue(layout.getText().replace("__NEWLINE__", "\n"));
+                selectedIsEditableProperty.setValue(true);
+            } else {
                 sourceTextProperty.setValue(((CitationStylePreviewLayout) selectedLayout).getSource());
                 selectedIsEditableProperty.setValue(false);
             }

From d782e041c4a95146ce06fcaf22f0f12820da3624 Mon Sep 17 00:00:00 2001
From: sahilsekr42 <100865986+sahilsekr42@users.noreply.github.com>
Date: Mon, 22 Apr 2024 12:05:38 +0530
Subject: [PATCH 10/28] fix import errors

---
 .../org/jabref/gui/preferences/preview/PreviewTabViewModel.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index 6e296591459..e40b27dec84 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -33,6 +33,7 @@
 import org.jabref.gui.util.CustomLocalDragboard;
 import org.jabref.gui.util.NoSelectionModel;
 import org.jabref.gui.util.TaskExecutor;
+import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.citationstyle.CitationStyle;
 import org.jabref.logic.citationstyle.CitationStylePreviewLayout;
 import org.jabref.logic.l10n.Localization;

From 212f7efaab1bae9eb49a73843f606bb002c629db Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 22 Apr 2024 22:24:41 +0200
Subject: [PATCH 11/28] better architecture

---
 .../preview/PreviewTabViewModel.java          | 31 ++++++++-----------
 .../gui/preview/CopyCitationAction.java       |  2 +-
 .../jabref/logic/bst/BstPreviewLayout.java    | 17 ++++++++--
 .../CitationStylePreviewLayout.java           |  5 +--
 .../logic/layout/TextBasedPreviewLayout.java  |  6 ++--
 .../jabref/logic/preview/PreviewLayout.java   |  7 ++++-
 6 files changed, 42 insertions(+), 26 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index e40b27dec84..03847130963 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -33,7 +33,6 @@
 import org.jabref.gui.util.CustomLocalDragboard;
 import org.jabref.gui.util.NoSelectionModel;
 import org.jabref.gui.util.TaskExecutor;
-import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.citationstyle.CitationStyle;
 import org.jabref.logic.citationstyle.CitationStylePreviewLayout;
 import org.jabref.logic.l10n.Localization;
@@ -53,11 +52,11 @@
 /**
  * This class is Preferences -> Entry Preview tab model
  * <p>
- *     {@link PreviewTab} is the controller of Entry Preview tab
+ * {@link PreviewTab} is the controller of Entry Preview tab
  * </p>
  *
  * @see PreviewTab
- * */
+ */
 public class PreviewTabViewModel implements PreferenceTabViewModel {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(PreviewTabViewModel.class);
@@ -104,10 +103,10 @@ public PreviewTabViewModel(DialogService dialogService,
                 chosenListProperty,
                 input -> !chosenListProperty.getValue().isEmpty(),
                 ValidationMessage.error("%s > %s %n %n %s".formatted(
-                        Localization.lang("Entry preview"),
-                        Localization.lang("Selected"),
-                        Localization.lang("Selected Layouts can not be empty")
-                )
+                                Localization.lang("Entry preview"),
+                                Localization.lang("Selected"),
+                                Localization.lang("Selected Layouts can not be empty")
+                        )
                 )
         );
     }
@@ -154,17 +153,13 @@ public void setPreviewLayout(PreviewLayout selectedLayout) {
                     Localization.lang("Parsing error") + ": " + Localization.lang("illegal backslash expression"), exception);
         }
 
-        if (selectedLayout instanceof BstPreviewLayout) {
-            // needs implementation of getSource() for bst layout otherwise throwing runtime error.
-        } else {
-            if (selectedLayout instanceof TextBasedPreviewLayout layout) {
-                sourceTextProperty.setValue(layout.getText().replace("__NEWLINE__", "\n"));
-                selectedIsEditableProperty.setValue(true);
-            } else {
-                sourceTextProperty.setValue(((CitationStylePreviewLayout) selectedLayout).getSource());
-                selectedIsEditableProperty.setValue(false);
-            }
-        }
+        boolean isEditingAllowed = selectedLayout instanceof TextBasedPreviewLayout;
+        setContentForPreview(selectedLayout.getText(), isEditingAllowed);
+    }
+
+    private void setContentForPreview(String text, boolean editable) {
+        sourceTextProperty.setValue(text);
+        selectedIsEditableProperty.setValue(editable);
     }
 
     public void refreshPreview() {
diff --git a/src/main/java/org/jabref/gui/preview/CopyCitationAction.java b/src/main/java/org/jabref/gui/preview/CopyCitationAction.java
index 164eec87b57..8abd4c6ba22 100644
--- a/src/main/java/org/jabref/gui/preview/CopyCitationAction.java
+++ b/src/main/java/org/jabref/gui/preview/CopyCitationAction.java
@@ -83,7 +83,7 @@ private List<String> generateCitations() throws IOException {
         PreviewLayout previewLayout = preferencesService.getPreviewPreferences().getSelectedPreviewLayout();
 
         if (previewLayout instanceof CitationStylePreviewLayout citationStyleLayout) {
-            styleSource = citationStyleLayout.getSource();
+            styleSource = citationStyleLayout.getText();
         }
 
         if (styleSource != null) {
diff --git a/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java b/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java
index 06a253968b9..c99d085393f 100644
--- a/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java
+++ b/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java
@@ -1,5 +1,6 @@
 package org.jabref.logic.bst;
 
+import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.List;
@@ -17,16 +18,23 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class BstPreviewLayout implements PreviewLayout {
+public final class BstPreviewLayout implements PreviewLayout {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(BstPreviewLayout.class);
 
     private final String name;
-
+    private String source;
     private BstVM bstVM;
     private String error;
 
     public BstPreviewLayout(Path path) {
+        try {
+            this.source = String.join("\n", Files.readAllLines(path));
+        } catch (IOException e) {
+            LOGGER.error("Error reading file", e);
+            this.source = "";
+        }
+
         name = path.getFileName().toString();
         if (!Files.exists(path)) {
             LOGGER.error("File {} not found", path.toAbsolutePath());
@@ -85,4 +93,9 @@ public String getDisplayName() {
     public String getName() {
         return name;
     }
+
+    @Override
+    public String getText() {
+        return source;
+    }
 }
diff --git a/src/main/java/org/jabref/logic/citationstyle/CitationStylePreviewLayout.java b/src/main/java/org/jabref/logic/citationstyle/CitationStylePreviewLayout.java
index 7e790c3ef0e..a83ffd9977a 100644
--- a/src/main/java/org/jabref/logic/citationstyle/CitationStylePreviewLayout.java
+++ b/src/main/java/org/jabref/logic/citationstyle/CitationStylePreviewLayout.java
@@ -5,7 +5,7 @@
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.BibEntryTypesManager;
 
-public class CitationStylePreviewLayout implements PreviewLayout {
+public final class CitationStylePreviewLayout implements PreviewLayout {
     private final CitationStyle citationStyle;
     private final BibEntryTypesManager bibEntryTypesManager;
 
@@ -24,7 +24,8 @@ public String getDisplayName() {
         return citationStyle.getTitle();
     }
 
-    public String getSource() {
+    @Override
+    public String getText() {
         return citationStyle.getSource();
     }
 
diff --git a/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java b/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java
index 80bdd02aa2d..29f99f25e86 100644
--- a/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java
+++ b/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java
@@ -15,7 +15,7 @@
 /**
  * Implements the preview based JabRef's <a href="https://docs.jabref.org/import-export/export/customexports">Custom export filters</a>.
  */
-public class TextBasedPreviewLayout implements PreviewLayout {
+public final class TextBasedPreviewLayout implements PreviewLayout {
     public static final String NAME = "PREVIEW";
 
     private static final Logger LOGGER = LoggerFactory.getLogger(TextBasedPreviewLayout.class);
@@ -54,8 +54,9 @@ public String generatePreview(BibEntry entry, BibDatabaseContext databaseContext
         }
     }
 
+    @Override
     public String getText() {
-        return text;
+        return text.replace("__NEWLINE__", "\n");
     }
 
     @Override
@@ -67,4 +68,5 @@ public String getName() {
     public String getDisplayName() {
         return Localization.lang("Customized preview style");
     }
+
 }
diff --git a/src/main/java/org/jabref/logic/preview/PreviewLayout.java b/src/main/java/org/jabref/logic/preview/PreviewLayout.java
index de3f327782c..484a057f9e2 100644
--- a/src/main/java/org/jabref/logic/preview/PreviewLayout.java
+++ b/src/main/java/org/jabref/logic/preview/PreviewLayout.java
@@ -2,18 +2,23 @@
 
 import java.util.Locale;
 
+import org.jabref.logic.bst.BstPreviewLayout;
+import org.jabref.logic.citationstyle.CitationStylePreviewLayout;
+import org.jabref.logic.layout.TextBasedPreviewLayout;
 import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.entry.BibEntry;
 
 /**
  * Used for displaying a rendered entry in the UI. Due to historical reasons, "rendering" is called "layout".
  */
-public interface PreviewLayout {
+public sealed interface PreviewLayout permits BstPreviewLayout, CitationStylePreviewLayout, TextBasedPreviewLayout {
 
     String generatePreview(BibEntry entry, BibDatabaseContext databaseContext);
 
     String getDisplayName();
 
+    String getText();
+
     String getName();
 
     default boolean containsCaseIndependent(String searchTerm) {

From 2a4db3b4aeaf40e71bc00e4296661132f26f1eba Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 22 Apr 2024 22:58:41 +0200
Subject: [PATCH 12/28] test ieeetran with test entry

---
 src/test/java/org/jabref/logic/bst/BstVMTest.java | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/test/java/org/jabref/logic/bst/BstVMTest.java b/src/test/java/org/jabref/logic/bst/BstVMTest.java
index 754c8b3767b..981cd1c23fc 100644
--- a/src/test/java/org/jabref/logic/bst/BstVMTest.java
+++ b/src/test/java/org/jabref/logic/bst/BstVMTest.java
@@ -5,6 +5,7 @@
 import java.util.Collections;
 import java.util.List;
 
+import org.jabref.logic.util.TestEntry;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.StandardField;
 import org.jabref.model.entry.types.StandardEntryType;
@@ -42,6 +43,20 @@ public void abbrv() throws RecognitionException, IOException {
                 result.replaceAll("\\s", ""));
     }
 
+
+    @Test
+    public void ieeetran() throws RecognitionException, IOException {
+        BstVM vm = new BstVM(Path.of("src/test/resources/org/jabref/logic/bst/IEEEtran.bst"));
+        List<BibEntry> testEntries = List.of(TestEntry.getTestEntry());
+
+        String expected = "\\begin{thebibliography}{1}\\bibitem{canh05}K.~Crowston, H.~Annabi, J.~Howison, and C.~Masango.\\newblock Effective work practices for floss development: A model and  propositions.\\newblock In {\\em Hawaii International Conference On System Sciences (HICSS)}, 2005.\\end{thebibliography}";
+        String result = vm.render(testEntries);
+
+        assertEquals(
+                expected.replaceAll("\\s", ""),
+                result.replaceAll("\\s", ""));
+    }
+
     @Test
     public void simple() throws RecognitionException {
         BstVM vm = new BstVM("""

From 1412d89b695a24ffe6448da17c28b3156e59cac1 Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 22 Apr 2024 22:59:21 +0200
Subject: [PATCH 13/28] fix

---
 src/test/java/org/jabref/logic/bst/BstVMTest.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/test/java/org/jabref/logic/bst/BstVMTest.java b/src/test/java/org/jabref/logic/bst/BstVMTest.java
index 981cd1c23fc..e405b65706e 100644
--- a/src/test/java/org/jabref/logic/bst/BstVMTest.java
+++ b/src/test/java/org/jabref/logic/bst/BstVMTest.java
@@ -43,7 +43,6 @@ public void abbrv() throws RecognitionException, IOException {
                 result.replaceAll("\\s", ""));
     }
 
-
     @Test
     public void ieeetran() throws RecognitionException, IOException {
         BstVM vm = new BstVM(Path.of("src/test/resources/org/jabref/logic/bst/IEEEtran.bst"));

From 41d357d8fbfad232e8910fb4abc7e3b6391d0d9c Mon Sep 17 00:00:00 2001
From: Oliver Kopp <kopp.dev@gmail.com>
Date: Thu, 25 Apr 2024 19:49:59 +0200
Subject: [PATCH 14/28] Fix path to IEEEtran.bst

---
 src/test/java/org/jabref/logic/bst/BstVMTest.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/java/org/jabref/logic/bst/BstVMTest.java b/src/test/java/org/jabref/logic/bst/BstVMTest.java
index e405b65706e..6ee2ad0dfcc 100644
--- a/src/test/java/org/jabref/logic/bst/BstVMTest.java
+++ b/src/test/java/org/jabref/logic/bst/BstVMTest.java
@@ -45,7 +45,7 @@ public void abbrv() throws RecognitionException, IOException {
 
     @Test
     public void ieeetran() throws RecognitionException, IOException {
-        BstVM vm = new BstVM(Path.of("src/test/resources/org/jabref/logic/bst/IEEEtran.bst"));
+        BstVM vm = new BstVM(Path.of("src/main/resources/bst/IEEEtran.bst"));
         List<BibEntry> testEntries = List.of(TestEntry.getTestEntry());
 
         String expected = "\\begin{thebibliography}{1}\\bibitem{canh05}K.~Crowston, H.~Annabi, J.~Howison, and C.~Masango.\\newblock Effective work practices for floss development: A model and  propositions.\\newblock In {\\em Hawaii International Conference On System Sciences (HICSS)}, 2005.\\end{thebibliography}";

From 730fbc7c668f8619f28ab5372374a26eb0119833 Mon Sep 17 00:00:00 2001
From: Oliver Kopp <kopp.dev@gmail.com>
Date: Thu, 25 Apr 2024 20:02:16 +0200
Subject: [PATCH 15/28] Streamline conversion to BstEntry

---
 src/main/java/org/jabref/logic/bst/BstVM.java | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/main/java/org/jabref/logic/bst/BstVM.java b/src/main/java/org/jabref/logic/bst/BstVM.java
index bb643572fe5..87db98b7a23 100644
--- a/src/main/java/org/jabref/logic/bst/BstVM.java
+++ b/src/main/java/org/jabref/logic/bst/BstVM.java
@@ -69,10 +69,7 @@ private static ParseTree charStream2CommonTree(CharStream query) {
     public String render(Collection<BibEntry> bibEntries, BibDatabase bibDatabase) {
         Objects.requireNonNull(bibEntries);
 
-        List<BstEntry> entries = new ArrayList<>(bibEntries.size());
-        for (BibEntry entry : bibEntries) {
-            entries.add(new BstEntry(entry));
-        }
+        List<BstEntry> entries = bibEntries.stream().map(BstEntry::new).toList();
 
         StringBuilder resultBuffer = new StringBuilder();
 

From 7a131e75928bc29ae8088fb395a92daca3c1a90e Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Thu, 25 Apr 2024 20:43:49 +0200
Subject: [PATCH 16/28] refactor file chooser

---
 .../gui/preferences/preview/PreviewTab.java   | 45 ++++++++++---------
 .../jabref/logic/util/StandardFileType.java   |  3 +-
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index dd01aff7951..a4c6f8884db 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -1,7 +1,5 @@
 package org.jabref.gui.preferences.preview;
 
-import java.io.File;
-import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -21,24 +19,25 @@
 import javafx.scene.input.KeyEvent;
 import javafx.scene.input.MouseEvent;
 import javafx.scene.input.TransferMode;
-import javafx.stage.FileChooser;
 
-import org.jabref.gui.Globals;
 import org.jabref.gui.StateManager;
 import org.jabref.gui.actions.ActionFactory;
 import org.jabref.gui.actions.SimpleCommand;
 import org.jabref.gui.actions.StandardActions;
 import org.jabref.gui.icon.IconTheme;
+import org.jabref.gui.keyboard.KeyBindingRepository;
 import org.jabref.gui.preferences.AbstractPreferenceTabView;
 import org.jabref.gui.preferences.PreferencesTab;
 import org.jabref.gui.preview.PreviewViewer;
 import org.jabref.gui.theme.ThemeManager;
 import org.jabref.gui.util.BindingsHelper;
+import org.jabref.gui.util.FileDialogConfiguration;
 import org.jabref.gui.util.IconValidationDecorator;
 import org.jabref.gui.util.ViewModelListCellFactory;
 import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.preview.PreviewLayout;
+import org.jabref.logic.util.StandardFileType;
 import org.jabref.logic.util.TestEntry;
 import org.jabref.model.database.BibDatabaseContext;
 
@@ -68,6 +67,7 @@ public class PreviewTab extends AbstractPreferenceTabView<PreviewTabViewModel> i
 
     @Inject private StateManager stateManager;
     @Inject private ThemeManager themeManager;
+    @Inject private KeyBindingRepository keyBindingRepository;
 
     private final ContextMenu contextMenu = new ContextMenu();
 
@@ -94,10 +94,14 @@ public EditAction(StandardActions command) {
         public void execute() {
             if (editArea != null) {
                 switch (command) {
-                    case COPY -> editArea.copy();
-                    case CUT -> editArea.cut();
-                    case PASTE -> editArea.paste();
-                    case SELECT_ALL -> editArea.selectAll();
+                    case COPY ->
+                            editArea.copy();
+                    case CUT ->
+                            editArea.cut();
+                    case PASTE ->
+                            editArea.paste();
+                    case SELECT_ALL ->
+                            editArea.selectAll();
                 }
                 editArea.requestFocus();
             }
@@ -111,18 +115,19 @@ public String getTabName() {
 
     @FXML
     private void selectBstFile(ActionEvent event) {
-    FileChooser fileChooser = new FileChooser();
-    fileChooser.setTitle("Select BST File");
-    fileChooser.getExtensionFilters().add(new FileChooser.ExtensionFilter("BST Files", "*.bst"));
-
-    File selectedFile = fileChooser.showOpenDialog(null);
-    if (selectedFile != null) {
-        String filePath = selectedFile.getAbsolutePath();
-        BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(Path.of(filePath));
-        viewModel.availableListProperty().add(bstPreviewLayout);
+
+        FileDialogConfiguration fileDialogConfiguration = new FileDialogConfiguration.Builder()
+                .addExtensionFilter(StandardFileType.BST)
+                .withDefaultExtension(StandardFileType.BST)
+                .withInitialDirectory(preferencesService.getFilePreferences().getWorkingDirectory())
+                .build();
+
+        dialogService.showFileOpenDialog(fileDialogConfiguration).ifPresent(bstFile -> {
+            BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(bstFile);
+            viewModel.availableListProperty().add(bstPreviewLayout);
+        });
     }
-}
-    
+
     public void initialize() {
         this.viewModel = new PreviewTabViewModel(dialogService, preferencesService.getPreviewPreferences(), taskExecutor, stateManager);
         lastKeyPressTime = System.currentTimeMillis();
@@ -133,7 +138,7 @@ public void initialize() {
         searchBox.setPromptText(Localization.lang("Search") + "...");
         searchBox.setLeft(IconTheme.JabRefIcons.SEARCH.getGraphicNode());
 
-        ActionFactory factory = new ActionFactory(Globals.getKeyPrefs());
+        ActionFactory factory = new ActionFactory(keyBindingRepository);
         contextMenu.getItems().addAll(
                 factory.createMenuItem(StandardActions.CUT, new EditAction(StandardActions.CUT)),
                 factory.createMenuItem(StandardActions.COPY, new EditAction(StandardActions.COPY)),
diff --git a/src/main/java/org/jabref/logic/util/StandardFileType.java b/src/main/java/org/jabref/logic/util/StandardFileType.java
index 904212a5d2a..e0464c4d1eb 100644
--- a/src/main/java/org/jabref/logic/util/StandardFileType.java
+++ b/src/main/java/org/jabref/logic/util/StandardFileType.java
@@ -18,6 +18,7 @@ public enum StandardFileType implements FileType {
     SILVER_PLATTER("SilverPlatter", "dat", "txt"),
     AUX("Aux file", "aux"),
     BIBTEX_DB("Bibtex library", "bib"),
+    BST("BibTeX-Style file", "bst"),
     CITATION_STYLE("Citation Style", "csl"),
     CLASS("Class file", "class"),
     CSV("CSV", "csv"),
@@ -71,6 +72,6 @@ public static FileType fromExtensions(String... extensions) {
         return OptionalUtil.orElse(Arrays.stream(StandardFileType.values())
                                          .filter(field -> field.getExtensions().stream().anyMatch(exts::contains))
                                          .findAny(),
-                                   new UnknownFileType(extensions));
+                new UnknownFileType(extensions));
     }
 }

From 8b04f6fd667354f9b9cdd883e7774104db2b660d Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Thu, 25 Apr 2024 20:44:32 +0200
Subject: [PATCH 17/28] checkstyle

---
 .../java/org/jabref/logic/layout/TextBasedPreviewLayout.java     | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java b/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java
index 29f99f25e86..328ea411a3d 100644
--- a/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java
+++ b/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java
@@ -68,5 +68,4 @@ public String getName() {
     public String getDisplayName() {
         return Localization.lang("Customized preview style");
     }
-
 }

From 04969c39a47519267f3930a73f50520a6977eff7 Mon Sep 17 00:00:00 2001
From: Oliver Kopp <kopp.dev@gmail.com>
Date: Thu, 25 Apr 2024 20:59:35 +0200
Subject: [PATCH 18/28] Somre more traces

---
 .../java/org/jabref/logic/bst/BstFunctions.java  |  8 +++++---
 .../java/org/jabref/logic/bst/BstVMVisitor.java  | 16 +++++++++++++---
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/jabref/logic/bst/BstFunctions.java b/src/main/java/org/jabref/logic/bst/BstFunctions.java
index 1e048da1a45..b046d30b0e2 100644
--- a/src/main/java/org/jabref/logic/bst/BstFunctions.java
+++ b/src/main/java/org/jabref/logic/bst/BstFunctions.java
@@ -310,9 +310,9 @@ private void bstAddPeriod(BstVMVisitor visitor, ParserRuleContext ctx) {
      * the book function. When given as an argument to the ITERATE
      * command, call.type$ actually produces the output for the entries.
      * For an entry with an unknown type, it executes the function
-     * default.type. Thus you should define (before the READ command)
+     * default.type. Thus, you should define (before the READ command)
      * one function for each standard entry type as well as a
-     * default.type function.
+     * <code>default.type</code> function.
      */
     public class BstCallTypeFunction implements BstFunction {
         @Override
@@ -325,7 +325,9 @@ public void execute(BstVMVisitor visitor, ParserRuleContext ctx, BstEntry bstEnt
             if (bstEntry == null) {
                 this.execute(visitor, ctx); // Throw error
             } else {
-                functions.get(bstEntry.entry.getType().getName()).execute(visitor, ctx, bstEntry);
+                String entryType = bstEntry.entry.getType().getName();
+                LOGGER.trace("Handling {}", entryType);
+                functions.get(entryType).execute(visitor, ctx, bstEntry);
             }
         }
     }
diff --git a/src/main/java/org/jabref/logic/bst/BstVMVisitor.java b/src/main/java/org/jabref/logic/bst/BstVMVisitor.java
index 1d19e5abc62..cc90a7c30e1 100644
--- a/src/main/java/org/jabref/logic/bst/BstVMVisitor.java
+++ b/src/main/java/org/jabref/logic/bst/BstVMVisitor.java
@@ -58,7 +58,9 @@ public Integer visitIntegersCommand(BstParser.IntegersCommandContext ctx) {
 
     @Override
     public Integer visitFunctionCommand(BstParser.FunctionCommandContext ctx) {
-        bstVMContext.functions().put(ctx.id.getText(),
+        String name = ctx.id.getText();
+        LOGGER.trace("Function: {}", name);
+        bstVMContext.functions().put(name,
                 (visitor, functionContext) -> visitor.visit(ctx.function));
         return BstVM.TRUE;
     }
@@ -115,13 +117,17 @@ public Integer visitReadCommand(BstParser.ReadCommandContext ctx) {
     @Override
     public Integer visitExecuteCommand(BstParser.ExecuteCommandContext ctx) {
         this.selectedBstEntry = null;
-        visit(ctx.bstFunction());
+        BstParser.BstFunctionContext bstFunction = ctx.bstFunction();
+        String name = bstFunction.getText();
+        LOGGER.trace("Executing function {}", name);
+        visit(bstFunction);
 
         return BstVM.TRUE;
     }
 
     @Override
     public Integer visitIterateCommand(BstParser.IterateCommandContext ctx) {
+        LOGGER.trace("EXECUTE {}", ctx.bstFunction().getText());
         for (BstEntry entry : bstVMContext.entries()) {
             this.selectedBstEntry = entry;
             visit(ctx.bstFunction());
@@ -182,7 +188,9 @@ public Integer visitSortCommand(BstParser.SortCommandContext ctx) {
 
     @Override
     public Integer visitIdentifier(BstParser.IdentifierContext ctx) {
-        resolveIdentifier(ctx.IDENTIFIER().getText(), ctx);
+        String name = ctx.IDENTIFIER().getText();
+        LOGGER.trace("Identifier: {}", name);
+        resolveIdentifier(name, ctx);
         return BstVM.TRUE;
     }
 
@@ -222,8 +230,10 @@ protected void resolveIdentifier(String name, ParserRuleContext ctx) {
     public Integer visitBstFunction(BstParser.BstFunctionContext ctx) {
         String name = ctx.getChild(0).getText();
         if (bstVMContext.functions().containsKey(name)) {
+            LOGGER.trace("Function {} found", name);
             bstVMContext.functions().get(name).execute(this, ctx, selectedBstEntry);
         } else {
+            LOGGER.trace("Function {} not found", name);
             visit(ctx.getChild(0));
         }
 

From 995856d716cbeb035170ec80725a649ad395fea1 Mon Sep 17 00:00:00 2001
From: Oliver Kopp <kopp.dev@gmail.com>
Date: Thu, 25 Apr 2024 21:26:52 +0200
Subject: [PATCH 19/28] Add ''

---
 src/main/java/org/jabref/logic/bst/BstVMVisitor.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/jabref/logic/bst/BstVMVisitor.java b/src/main/java/org/jabref/logic/bst/BstVMVisitor.java
index cc90a7c30e1..d2955e3fa16 100644
--- a/src/main/java/org/jabref/logic/bst/BstVMVisitor.java
+++ b/src/main/java/org/jabref/logic/bst/BstVMVisitor.java
@@ -230,10 +230,10 @@ protected void resolveIdentifier(String name, ParserRuleContext ctx) {
     public Integer visitBstFunction(BstParser.BstFunctionContext ctx) {
         String name = ctx.getChild(0).getText();
         if (bstVMContext.functions().containsKey(name)) {
-            LOGGER.trace("Function {} found", name);
+            LOGGER.trace("Function '{}' found", name);
             bstVMContext.functions().get(name).execute(this, ctx, selectedBstEntry);
         } else {
-            LOGGER.trace("Function {} not found", name);
+            LOGGER.trace("Function '{}' not found", name);
             visit(ctx.getChild(0));
         }
 

From efb9e19c75feaed6f8d83d0c9f0e54d9e4031fbb Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Sun, 19 May 2024 20:50:41 +0200
Subject: [PATCH 20/28] checkstyle

---
 src/main/java/org/jabref/logic/bst/BstVM.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/org/jabref/logic/bst/BstVM.java b/src/main/java/org/jabref/logic/bst/BstVM.java
index 87db98b7a23..f5d9dbafa6d 100644
--- a/src/main/java/org/jabref/logic/bst/BstVM.java
+++ b/src/main/java/org/jabref/logic/bst/BstVM.java
@@ -2,7 +2,6 @@
 
 import java.io.IOException;
 import java.nio.file.Path;
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Deque;
 import java.util.List;

From 773faa4e28bf21631f28a954921a01f4c0355db0 Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Sun, 19 May 2024 20:52:23 +0200
Subject: [PATCH 21/28] checkstyle

---
 src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index a4c6f8884db..ae29cd9d32f 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -115,7 +115,6 @@ public String getTabName() {
 
     @FXML
     private void selectBstFile(ActionEvent event) {
-
         FileDialogConfiguration fileDialogConfiguration = new FileDialogConfiguration.Builder()
                 .addExtensionFilter(StandardFileType.BST)
                 .withDefaultExtension(StandardFileType.BST)

From 1a0a23a365f880228b432549d21b9485fe6e5f92 Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 11:47:36 +0200
Subject: [PATCH 22/28] move button up

Fix NPE
add preview to chosen
---
 .../org/jabref/gui/preferences/preview/PreviewTab.fxml    | 2 +-
 .../org/jabref/gui/preferences/preview/PreviewTab.java    | 1 +
 src/main/java/org/jabref/logic/bst/BstFunctions.java      | 8 ++++++--
 src/main/resources/l10n/JabRef_en.properties              | 2 ++
 4 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml
index 2e7c2b27126..4fc150ee8c4 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.fxml
@@ -21,8 +21,8 @@
     <Label text="%Current Preview" styleClass="titleHeader"/>
     <CheckBox fx:id="showAsTabCheckBox" text="%Show preview as a tab in entry editor"/>
     <CheckBox fx:id="showPreviewTooltipCheckBox" text="Show preview in entry table tooltip"/>
+    <Button fx:id="bstFileButton" text="%Add BST file" onAction="#selectBstFile" />
     <HBox spacing="4.0">
-        <Button fx:id="bstFileButton" text="Select BST File" onAction="#selectBstFile" />
         <VBox spacing="4.0" HBox.hgrow="ALWAYS">
             <Label text="%Available" styleClass="sectionHeader"/>
             <CustomTextField fx:id="searchBox" promptText="%Filter" VBox.vgrow="NEVER" prefHeight="20.0"/>
diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index ae29cd9d32f..07c8eb9eec0 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -124,6 +124,7 @@ private void selectBstFile(ActionEvent event) {
         dialogService.showFileOpenDialog(fileDialogConfiguration).ifPresent(bstFile -> {
             BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(bstFile);
             viewModel.availableListProperty().add(bstPreviewLayout);
+            viewModel.chosenListProperty().add(bstPreviewLayout);
         });
     }
 
diff --git a/src/main/java/org/jabref/logic/bst/BstFunctions.java b/src/main/java/org/jabref/logic/bst/BstFunctions.java
index c12826168bf..dbe1f44006e 100644
--- a/src/main/java/org/jabref/logic/bst/BstFunctions.java
+++ b/src/main/java/org/jabref/logic/bst/BstFunctions.java
@@ -164,7 +164,7 @@ private void bstEquals(BstVMVisitor visitor, ParserRuleContext ctx) {
     }
 
     /**
-     *  Pops the top two (integer) literals and pushes their sum.
+     * Pops the top two (integer) literals and pushes their sum.
      */
     private void bstAdd(BstVMVisitor visitor, ParserRuleContext ctx) {
         if (stack.size() < 2) {
@@ -328,6 +328,10 @@ public void execute(BstVMVisitor visitor, ParserRuleContext ctx, BstEntry bstEnt
             } else {
                 String entryType = bstEntry.entry.getType().getName();
                 LOGGER.trace("Handling {}", entryType);
+                if (!functions.containsKey(entryType)) {
+                    LOGGER.error("Function for {} not found ", entryType);
+                    return;
+                }
                 functions.get(entryType).execute(visitor, ctx, bstEntry);
             }
         }
@@ -753,7 +757,7 @@ private void bstSwap(BstVMVisitor visitor, ParserRuleContext ctx) {
      * precisely, a "special character", defined in Section 4) counts as
      * a single text character, even if it's missing its matching right
      * brace, and where braces don't count as text characters.
-     *
+     * <p>
      * From BibTeXing: For the purposes of counting letters in labels,
      * BibTEX considers everything contained inside the braces as a
      * single letter.
diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
index 21c49a26efb..07b38d07b25 100644
--- a/src/main/resources/l10n/JabRef_en.properties
+++ b/src/main/resources/l10n/JabRef_en.properties
@@ -665,6 +665,8 @@ Preferences\ recorded.=Preferences recorded.
 Preview=Preview
 Citation\ Style=Citation Style
 Current\ Preview=Current Preview
+Add\ BST\ file=Add BST file
+
 Cannot\ generate\ preview\ based\ on\ selected\ citation\ style.=Cannot generate preview based on selected citation style.
 Bad\ character\ inside\ entry=Bad character inside entry
 Error\ while\ generating\ citation\ style=Error while generating citation style

From 83b4cbb3de98e7774fe97aaea954debd585ee41b Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 12:55:32 +0200
Subject: [PATCH 23/28] Fix storing of style in Preferences add to layout cycle

Apply some intellij logger suggestions
---
 .../gui/preferences/preview/PreviewTab.java   |  5 +--
 .../preview/PreviewTabViewModel.java          | 22 +++++++++-
 .../org/jabref/logic/bst/BstFunctions.java    |  4 +-
 .../jabref/logic/bst/BstPreviewLayout.java    |  8 ++++
 .../jabref/preferences/JabRefPreferences.java | 42 +++++++++++++------
 .../preferences/PreviewPreferences.java       | 14 ++++++-
 6 files changed, 76 insertions(+), 19 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index 07c8eb9eec0..adc91474e8a 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -121,10 +121,9 @@ private void selectBstFile(ActionEvent event) {
                 .withInitialDirectory(preferencesService.getFilePreferences().getWorkingDirectory())
                 .build();
 
+
         dialogService.showFileOpenDialog(fileDialogConfiguration).ifPresent(bstFile -> {
-            BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(bstFile);
-            viewModel.availableListProperty().add(bstPreviewLayout);
-            viewModel.chosenListProperty().add(bstPreviewLayout);
+            viewModel.addBstStyle(bstFile);
         });
     }
 
diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index 03847130963..55c0f8afa60 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -1,5 +1,6 @@
 package org.jabref.gui.preferences.preview;
 
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -11,6 +12,7 @@
 import javafx.beans.property.BooleanProperty;
 import javafx.beans.property.ListProperty;
 import javafx.beans.property.ObjectProperty;
+import javafx.beans.property.Property;
 import javafx.beans.property.SimpleBooleanProperty;
 import javafx.beans.property.SimpleListProperty;
 import javafx.beans.property.SimpleObjectProperty;
@@ -33,6 +35,7 @@
 import org.jabref.gui.util.CustomLocalDragboard;
 import org.jabref.gui.util.NoSelectionModel;
 import org.jabref.gui.util.TaskExecutor;
+import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.citationstyle.CitationStyle;
 import org.jabref.logic.citationstyle.CitationStylePreviewLayout;
 import org.jabref.logic.l10n.Localization;
@@ -70,6 +73,8 @@ public class PreviewTabViewModel implements PreferenceTabViewModel {
     private final ListProperty<PreviewLayout> chosenListProperty = new SimpleListProperty<>(FXCollections.observableArrayList());
     private final ObjectProperty<MultipleSelectionModel<PreviewLayout>> chosenSelectionModelProperty = new SimpleObjectProperty<>(new NoSelectionModel<>());
 
+    private final ListProperty<Path> bstStylesPaths = new SimpleListProperty<>(FXCollections.observableArrayList());
+
     private final BooleanProperty selectedIsEditableProperty = new SimpleBooleanProperty(false);
     private final ObjectProperty<PreviewLayout> selectedLayoutProperty = new SimpleObjectProperty<>();
     private final StringProperty sourceTextProperty = new SimpleStringProperty("");
@@ -123,6 +128,7 @@ public void setValues() {
             availableListProperty.getValue().add(previewPreferences.getCustomPreviewLayout());
         }
 
+
         BackgroundTask.wrap(CitationStyle::discoverCitationStyles)
                       .onSuccess(styles -> styles.stream()
                                                  .map(style -> new CitationStylePreviewLayout(style, Globals.entryTypesManager))
@@ -135,6 +141,12 @@ public void setValues() {
                           dialogService.showErrorDialogAndWait(Localization.lang("Error adding discovered CitationStyles"), ex);
                       })
                       .executeWith(taskExecutor);
+        bstStylesPaths.clear();
+        bstStylesPaths.addAll(previewPreferences.getBstPreviewLayoutPaths());
+        bstStylesPaths.forEach(path -> {
+            BstPreviewLayout layout = new BstPreviewLayout(path);
+            availableListProperty.add(layout);
+        });
     }
 
     public void setPreviewLayout(PreviewLayout selectedLayout) {
@@ -194,10 +206,11 @@ public void storeSettings() {
         previewPreferences.setShowPreviewAsExtraTab(showAsExtraTabProperty.getValue());
         previewPreferences.setShowPreviewEntryTableTooltip(showPreviewInEntryTableTooltip.getValue());
         previewPreferences.setCustomPreviewLayout((TextBasedPreviewLayout) customLayout);
+        previewPreferences.setBstPreviewLayoutPaths(bstStylesPaths);
 
         if (!chosenSelectionModelProperty.getValue().getSelectedItems().isEmpty()) {
             previewPreferences.setLayoutCyclePosition(chosenListProperty.getValue().indexOf(
-                    chosenSelectionModelProperty.getValue().getSelectedItems().get(0)));
+                    chosenSelectionModelProperty.getValue().getSelectedItems().getFirst()));
         }
     }
 
@@ -483,4 +496,11 @@ public ObjectProperty<PreviewLayout> selectedLayoutProperty() {
     public StringProperty sourceTextProperty() {
         return sourceTextProperty;
     }
+
+    public void addBstStyle(Path bstFile) {
+        BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(bstFile);
+        bstStylesPaths.add(bstFile);
+        availableListProperty().add(bstPreviewLayout);
+        chosenListProperty().add(bstPreviewLayout);
+    }
 }
diff --git a/src/main/java/org/jabref/logic/bst/BstFunctions.java b/src/main/java/org/jabref/logic/bst/BstFunctions.java
index dbe1f44006e..3eab0713a87 100644
--- a/src/main/java/org/jabref/logic/bst/BstFunctions.java
+++ b/src/main/java/org/jabref/logic/bst/BstFunctions.java
@@ -306,7 +306,7 @@ private void bstAddPeriod(BstVMVisitor visitor, ParserRuleContext ctx) {
     }
 
     /**
-     * Executes the function whose name is the entry type of an entry.
+     * Executes the function whose name is the entry type of entry.
      * For example if an entry is of type book, this function executes
      * the book function. When given as an argument to the ITERATE
      * command, call.type$ actually produces the output for the entries.
@@ -447,7 +447,7 @@ private void bstEmpty(BstVMVisitor visitor, ParserRuleContext ctx) {
             throw new BstVMException("Operand does not match function empty$ (line %d)".formatted(ctx.start.getLine()));
         }
 
-        boolean result = "".equals(s.trim());
+        boolean result = s.trim().isEmpty();
         LOGGER.trace("empty$({}) result: {}", s, result);
         stack.push(result ? BstVM.TRUE : BstVM.FALSE);
     }
diff --git a/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java b/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java
index c99d085393f..f32b9e21e6f 100644
--- a/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java
+++ b/src/main/java/org/jabref/logic/bst/BstPreviewLayout.java
@@ -12,6 +12,7 @@
 import org.jabref.logic.layout.format.RemoveLatexCommandsFormatter;
 import org.jabref.logic.layout.format.RemoveTilde;
 import org.jabref.logic.preview.PreviewLayout;
+import org.jabref.logic.util.StandardFileType;
 import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.entry.BibEntry;
 
@@ -98,4 +99,11 @@ public String getName() {
     public String getText() {
         return source;
     }
+
+    /**
+     * Checks if the given style file is a BST file by checking the extension
+     */
+    public static boolean isBstStyleFile(String styleFile) {
+        return StandardFileType.BST.getExtensions().stream().anyMatch(styleFile::endsWith);
+    }
 }
diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java
index 59b01569a34..8db0f09c876 100644
--- a/src/main/java/org/jabref/preferences/JabRefPreferences.java
+++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java
@@ -63,6 +63,7 @@
 import org.jabref.gui.theme.Theme;
 import org.jabref.logic.JabRefException;
 import org.jabref.logic.bibtex.FieldPreferences;
+import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.citationkeypattern.CitationKeyPattern;
 import org.jabref.logic.citationkeypattern.CitationKeyPatternPreferences;
 import org.jabref.logic.citationkeypattern.GlobalCitationKeyPatterns;
@@ -386,6 +387,7 @@ public class JabRefPreferences implements PreferencesService {
     public static final String CYCLE_PREVIEW = "cyclePreview";
     public static final String PREVIEW_AS_TAB = "previewAsTab";
     public static final String PREVIEW_IN_ENTRY_TABLE_TOOLTIP = "previewInEntryTableTooltip";
+    public static final String PREVIEW_BST_LAYOUT_PATHS = "previewBstLayoutPaths";
 
     // UI
     private static final String FONT_FAMILY = "fontFamily";
@@ -515,7 +517,7 @@ private JabRefPreferences() {
                 importPreferences(Path.of("jabref.xml"));
             }
         } catch (JabRefException e) {
-            LOGGER.warn("Could not import preferences from jabref.xml: " + e.getMessage(), e);
+            LOGGER.warn("Could not import preferences from jabref.xml: {}", e.getMessage(), e);
         }
 
         // load user preferences
@@ -1088,7 +1090,7 @@ public void flush() {
             try {
                 exportPreferences(Path.of("jabref.xml"));
             } catch (JabRefException e) {
-                LOGGER.warn("Could not export preferences for memory stick mode: " + e.getMessage(), e);
+                LOGGER.warn("Could not export preferences for memory stick mode: {}", e.getMessage(), e);
             }
         }
         try {
@@ -1643,7 +1645,7 @@ private String getProxyPassword() {
             } catch (PasswordAccessException ex) {
                 LOGGER.warn("JabRef uses proxy password from key store but no password is stored");
             } catch (Exception ex) {
-                LOGGER.warn("JabRef could not open the key store");
+                LOGGER.warn("JabRef could not open the key store", ex);
             }
         }
         return (String) defaults.get(PROXY_PASSWORD);
@@ -2110,7 +2112,8 @@ public InternalPreferences getInternalPreferences() {
             if (!newValue) {
                 try {
                     Files.deleteIfExists(Path.of("jabref.xml"));
-                } catch (IOException e) {
+                } catch (
+                        IOException e) {
                     LOGGER.warn("Error accessing filesystem", e);
                 }
             }
@@ -2431,17 +2434,25 @@ public PreviewPreferences getPreviewPreferences() {
                 new TextBasedPreviewLayout(style, getLayoutFormatterPreferences(), Globals.journalAbbreviationRepository),
                 (String) defaults.get(PREVIEW_STYLE),
                 getBoolean(PREVIEW_AS_TAB),
-                getBoolean(PREVIEW_IN_ENTRY_TABLE_TOOLTIP));
+                getBoolean(PREVIEW_IN_ENTRY_TABLE_TOOLTIP),
+                getStringList(PREVIEW_BST_LAYOUT_PATHS).stream()
+                                                       .map(Path::of)
+                                                       .collect(Collectors.toList())
+        );
 
         previewPreferences.getLayoutCycle().addListener((InvalidationListener) c -> storePreviewLayouts(previewPreferences.getLayoutCycle()));
         EasyBind.listen(previewPreferences.layoutCyclePositionProperty(), (obs, oldValue, newValue) -> putInt(CYCLE_PREVIEW_POS, newValue));
         EasyBind.listen(previewPreferences.customPreviewLayoutProperty(), (obs, oldValue, newValue) -> put(PREVIEW_STYLE, newValue.getText()));
         EasyBind.listen(previewPreferences.showPreviewAsExtraTabProperty(), (obs, oldValue, newValue) -> putBoolean(PREVIEW_AS_TAB, newValue));
         EasyBind.listen(previewPreferences.showPreviewEntryTableTooltip(), (obs, oldValue, newValue) -> putBoolean(PREVIEW_IN_ENTRY_TABLE_TOOLTIP, newValue));
-
+        previewPreferences.getBstPreviewLayoutPaths().addListener((InvalidationListener) c -> storeBstPaths(previewPreferences.getBstPreviewLayoutPaths()));
         return this.previewPreferences;
     }
 
+    private void storeBstPaths(List<Path> bstPaths) {
+        putStringList(PREVIEW_BST_LAYOUT_PATHS, bstPaths.stream().map(Path::toAbsolutePath).map(Path::toString).toList());
+    }
+
     private List<PreviewLayout> getPreviewLayouts(String style) {
         List<String> cycle = getStringList(CYCLE_PREVIEW);
 
@@ -2456,11 +2467,17 @@ private List<PreviewLayout> getPreviewLayouts(String style) {
                             return CitationStyle.createCitationStyleFromFile(layout)
                                                 .map(file -> (PreviewLayout) new CitationStylePreviewLayout(file, Globals.entryTypesManager))
                                                 .orElse(null);
+                        }
+                        if (BstPreviewLayout.isBstStyleFile(layout)) {
+                            return getStringList(PREVIEW_BST_LAYOUT_PATHS).stream()
+                                                                          .filter(path -> path.endsWith(layout)).map(Path::of)
+                                                                          .map(file -> (BstPreviewLayout) new BstPreviewLayout(file))
+                                                                          .findFirst()
+                                                                          .orElse(null);
                         } else {
                             return new TextBasedPreviewLayout(style, getLayoutFormatterPreferences(), Globals.journalAbbreviationRepository);
                         }
-                    })
-                    .filter(Objects::nonNull)
+                    }).filter(Objects::nonNull)
                     .collect(Collectors.toList());
     }
 
@@ -2541,9 +2558,9 @@ private Map<SidePaneType, Integer> getSidePanePreferredPositions() {
                 SidePaneType type = Enum.valueOf(SidePaneType.class, name);
                 preferredPositions.put(type, Integer.parseInt(componentPositions.get(i)));
             } catch (NumberFormatException e) {
-                LOGGER.debug("Invalid number format for side pane component '" + name + "'", e);
+                LOGGER.debug("Invalid number format for side pane component '{}'", name, e);
             } catch (IllegalArgumentException e) {
-                LOGGER.debug("Following component is not a side pane: '" + name + "'", e);
+                LOGGER.debug("Following component is not a side pane: '{}'", name, e);
             }
         }
 
@@ -3016,7 +3033,8 @@ private void storeFetcherKeysToKeyring(List<String> names, List<String> keys) {
                 if (StringUtil.isNullOrEmpty(keys.get(i))) {
                     try {
                         keyring.deletePassword("org.jabref.customapikeys", names.get(i));
-                    } catch (PasswordAccessException ex) {
+                    } catch (
+                            PasswordAccessException ex) {
                         // Already removed
                     }
                 } else {
@@ -3027,7 +3045,7 @@ private void storeFetcherKeysToKeyring(List<String> names, List<String> keys) {
                 }
             }
         } catch (Exception ex) {
-            LOGGER.error("Unable to open key store");
+            LOGGER.error("Unable to open key store", ex);
         }
     }
 
diff --git a/src/main/java/org/jabref/preferences/PreviewPreferences.java b/src/main/java/org/jabref/preferences/PreviewPreferences.java
index 563efd0071c..3d607724dc7 100644
--- a/src/main/java/org/jabref/preferences/PreviewPreferences.java
+++ b/src/main/java/org/jabref/preferences/PreviewPreferences.java
@@ -1,5 +1,6 @@
 package org.jabref.preferences;
 
+import java.nio.file.Path;
 import java.util.List;
 
 import javafx.beans.property.BooleanProperty;
@@ -24,19 +25,22 @@ public class PreviewPreferences {
     private final StringProperty defaultCustomPreviewLayout;
     private final BooleanProperty showPreviewAsExtraTab;
     private final BooleanProperty showPreviewEntryTableTooltip;
+    private final ObservableList<Path> bstPreviewLayoutPaths;
 
     public PreviewPreferences(List<PreviewLayout> layoutCycle,
                               int layoutCyclePosition,
                               TextBasedPreviewLayout customPreviewLayout,
                               String defaultCustomPreviewLayout,
                               boolean showPreviewAsExtraTab,
-                              boolean showPreviewEntryTableTooltip) {
+                              boolean showPreviewEntryTableTooltip,
+                              List<Path> bstPreviewLayoutPaths) {
         this.layoutCycle = FXCollections.observableArrayList(layoutCycle);
         this.layoutCyclePosition = new SimpleIntegerProperty(layoutCyclePosition);
         this.customPreviewLayout = new SimpleObjectProperty<>(customPreviewLayout);
         this.defaultCustomPreviewLayout = new SimpleStringProperty(defaultCustomPreviewLayout);
         this.showPreviewAsExtraTab = new SimpleBooleanProperty(showPreviewAsExtraTab);
         this.showPreviewEntryTableTooltip = new SimpleBooleanProperty(showPreviewEntryTableTooltip);
+        this.bstPreviewLayoutPaths = FXCollections.observableList(bstPreviewLayoutPaths);
     }
 
     public ObservableList<PreviewLayout> getLayoutCycle() {
@@ -112,4 +116,12 @@ public void setShowPreviewEntryTableTooltip(boolean showPreviewEntryTableTooltip
     public BooleanProperty showPreviewEntryTableTooltip() {
         return showPreviewEntryTableTooltip;
     }
+
+    public ObservableList<Path> getBstPreviewLayoutPaths() {
+        return bstPreviewLayoutPaths;
+    }
+
+    public void setBstPreviewLayoutPaths(List<Path> bstPreviewLayoutPaths) {
+        this.bstPreviewLayoutPaths.setAll(bstPreviewLayoutPaths);
+    }
 }

From 380aa6b60e77060cf924b7c7d8e003633cd9bb83 Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 13:02:31 +0200
Subject: [PATCH 24/28] wording of changelog

---
 CHANGELOG.md                                                | 2 +-
 src/main/java/org/jabref/preferences/JabRefPreferences.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 98029604043..6ba222766b1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,7 +19,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - Added a formatter to remove word enclosing braces. [#11222](https://github.com/JabRef/jabref/issues/11222)
 - We added the ability to add a keyword/crossref when typing the separator character (e.g., comma) in the keywords/crossref fields. [#11178](https://github.com/JabRef/jabref/issues/11178)
 - We added an exporter and improved the importer for Endnote XML format. [#11137](https://github.com/JabRef/jabref/issues/11137)
-- We added a button in gui to give users an easy option to select and add local bst files to available styles in preview layout list. [#11102](https://github.com/JabRef/jabref/issues/11102)
+- We added support for using BibTeX Style files (BST) in the Preview. [#11102](https://github.com/JabRef/jabref/issues/11102)
 - We added support for automatically update LaTeX citations when a LaTeX file is created, removed, or modified. [#10585](https://github.com/JabRef/jabref/issues/10585)
 
 ### Changed
diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java
index 8db0f09c876..880ce6b3340 100644
--- a/src/main/java/org/jabref/preferences/JabRefPreferences.java
+++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java
@@ -175,7 +175,7 @@ public class JabRefPreferences implements PreferencesService {
     public static final String NAMES_AS_IS = "namesAsIs";
     public static final String ENTRY_EDITOR_HEIGHT = "entryEditorHeightFX";
     /**
-     *  Holds the horizontal divider position of the preview view when it is shown inside the entry editor
+     * Holds the horizontal divider position of the preview view when it is shown inside the entry editor
      */
     public static final String ENTRY_EDITOR_PREVIEW_DIVIDER_POS = "entryEditorPreviewDividerPos";
     public static final String AUTO_RESIZE_MODE = "autoResizeMode";

From a3aaf3f80c1894f5aa4b65a568c5bc84250905b0 Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 13:05:03 +0200
Subject: [PATCH 25/28] cehckstyle

---
 .../org/jabref/gui/preferences/preview/PreviewTabViewModel.java  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index 55c0f8afa60..fd35a512213 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -12,7 +12,6 @@
 import javafx.beans.property.BooleanProperty;
 import javafx.beans.property.ListProperty;
 import javafx.beans.property.ObjectProperty;
-import javafx.beans.property.Property;
 import javafx.beans.property.SimpleBooleanProperty;
 import javafx.beans.property.SimpleListProperty;
 import javafx.beans.property.SimpleObjectProperty;

From 574c87d310b8a976c1975e8c8a4d491a2eebcc80 Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 13:27:13 +0200
Subject: [PATCH 26/28] checkstyle

---
 .../java/org/jabref/gui/preferences/preview/PreviewTab.java     | 2 --
 .../org/jabref/gui/preferences/preview/PreviewTabViewModel.java | 1 -
 2 files changed, 3 deletions(-)

diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
index adc91474e8a..4a66c9ee5ba 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
@@ -34,7 +34,6 @@
 import org.jabref.gui.util.FileDialogConfiguration;
 import org.jabref.gui.util.IconValidationDecorator;
 import org.jabref.gui.util.ViewModelListCellFactory;
-import org.jabref.logic.bst.BstPreviewLayout;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.preview.PreviewLayout;
 import org.jabref.logic.util.StandardFileType;
@@ -121,7 +120,6 @@ private void selectBstFile(ActionEvent event) {
                 .withInitialDirectory(preferencesService.getFilePreferences().getWorkingDirectory())
                 .build();
 
-
         dialogService.showFileOpenDialog(fileDialogConfiguration).ifPresent(bstFile -> {
             viewModel.addBstStyle(bstFile);
         });
diff --git a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
index fd35a512213..66b55041740 100644
--- a/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
+++ b/src/main/java/org/jabref/gui/preferences/preview/PreviewTabViewModel.java
@@ -127,7 +127,6 @@ public void setValues() {
             availableListProperty.getValue().add(previewPreferences.getCustomPreviewLayout());
         }
 
-
         BackgroundTask.wrap(CitationStyle::discoverCitationStyles)
                       .onSuccess(styles -> styles.stream()
                                                  .map(style -> new CitationStylePreviewLayout(style, Globals.entryTypesManager))

From 57aa305dd1eb24f7a913dcacf4fa8ab02521f31a Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 13:41:26 +0200
Subject: [PATCH 27/28] fix line break

---
 src/main/java/org/jabref/preferences/JabRefPreferences.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java
index 880ce6b3340..295bc277991 100644
--- a/src/main/java/org/jabref/preferences/JabRefPreferences.java
+++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java
@@ -2112,8 +2112,7 @@ public InternalPreferences getInternalPreferences() {
             if (!newValue) {
                 try {
                     Files.deleteIfExists(Path.of("jabref.xml"));
-                } catch (
-                        IOException e) {
+                } catch (IOException e) {
                     LOGGER.warn("Error accessing filesystem", e);
                 }
             }

From 225dab0699b818dd3d7737d4d4c16dcaf9a3d41e Mon Sep 17 00:00:00 2001
From: Siedlerchr <siedlerkiller@gmail.com>
Date: Mon, 20 May 2024 13:42:08 +0200
Subject: [PATCH 28/28] damn style

---
 src/main/java/org/jabref/preferences/JabRefPreferences.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java
index 295bc277991..0d90ffa60f8 100644
--- a/src/main/java/org/jabref/preferences/JabRefPreferences.java
+++ b/src/main/java/org/jabref/preferences/JabRefPreferences.java
@@ -3032,8 +3032,7 @@ private void storeFetcherKeysToKeyring(List<String> names, List<String> keys) {
                 if (StringUtil.isNullOrEmpty(keys.get(i))) {
                     try {
                         keyring.deletePassword("org.jabref.customapikeys", names.get(i));
-                    } catch (
-                            PasswordAccessException ex) {
+                    } catch (PasswordAccessException ex) {
                         // Already removed
                     }
                 } else {