Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install browser extension automatically on Windows #11924

Merged

Conversation

CraftyDH
Copy link
Contributor

Installs the JabRef browser extension on app install, closes #6076.

Implemented for both Chrome and Edge.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@InAnYan
Copy link
Collaborator

InAnYan commented Oct 12, 2024

Hi, @CraftyDH! Can you tell me what exactly you did in the PR?

"Install extension automatically" - what does this mean? It means it will install an extension in background without my consent? Or maybe not?

Never heard of .wsf files 😄. What a strange file where you have to include source code into a string... What exactly is there in the additions to .wsf file?

@CraftyDH
Copy link
Contributor Author

@InAnYan as per the Chrome documentation (linked in the issue), I have added the extension into the registry to request install. This was achieved by adding some code into the .wsf file, this file is a component of the tool we use (wix) to create the Windows installer.

This means that when Chrome/Edge is next opened, it will download and inform the user that the extension has been externally added and if they would like to enable or remove it.

The popup after relaunching the browser looks like this:
image

@InAnYan
Copy link
Collaborator

InAnYan commented Oct 12, 2024

@CraftyDH, what a strange API...

Do I understand properly, that extension are not directly installed, but this rather just a request to install, right?

Is there any way to add some checkboxes to installer like Install browser extension, that would be turned on by default? And if they are turned off, then nothing will happen.

Oh, and it would be nice if you left a comment in the .wsf file describing how you modify the registry and what are the effects of this (#11924 (comment))

@Siedlerchr
Copy link
Member

@InAnYan I am fine with this approach. This wsf stuff and Wix installer toolset is a hell (we needed it at work to customize a jpackage service installation). However some comments would be nice

Siedlerchr
Siedlerchr previously approved these changes Oct 15, 2024
@calixtus
Copy link
Member

It is weird,.. We would really appreciate a followup PR for Firefox if you like?
If not, we should create an issue.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 15, 2024
Merged via the queue into JabRef:main with commit 0e08b24 Oct 15, 2024
23 checks passed
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
Co-authored-by: Christoph <siedlerkiller@gmail.com>
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
Co-authored-by: Christoph <siedlerkiller@gmail.com>
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 21, 2024
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install chrome extension automatically
4 participants