Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer Code Signing #1879 #2320

Merged
merged 4 commits into from
Dec 2, 2016
Merged

Installer Code Signing #1879 #2320

merged 4 commits into from
Dec 2, 2016

Conversation

stefan-kolb
Copy link
Member

  • Change in CHANGELOG.md described
  • Win
  • OSX

@koppor
Copy link
Member

koppor commented Nov 29, 2016

LGTM

@stefan-kolb
Copy link
Member Author

stefan-kolb commented Nov 29, 2016

Can someone please try this on OSX @chochreiner. I also signed the dmg but I'm not sure that this works with the current certificate (even quite sure that it doesn't).
https://builds.jabref.org/cert/

@behrinml
Copy link

Standard response (double click):
screen shot 2016-11-29 at 16 53 18

By right click -> open:
screen shot 2016-11-29 at 16 53 31

With the signed version:
screen shot 2016-11-29 at 16 59 42

So it seems to work but gives of course the standard warning for Applications from outside the App Store.

@chochreiner
Copy link
Collaborator

hmm
for me, there is no difference between the app from the master and the cert branch
Which certificate are you currently using?

@behrinml
Copy link

Which settings do you have for installing applications? For me it is set to "Allow apps downloaded from Mac App Store and identified developers".

I think if you use one of the other two settings there will be no differences between the builds...

@chochreiner
Copy link
Collaborator

For me its: "App Store and identified developers" (on MacOS Sierra)

@behrinml
Copy link

Ok.. Now I am confused. Just checked on MacOS Sierra from a colleague and there is no difference between the builds. Maybe it is something about the OS (I am using OS X El Capitan) or I have changed something else which interferes, f.e. disabled SIP to get Spaces back, but this shouldn't make a difference. I can check next week on OS X Mavericks or later today on Mac OS X Snow Leopard.. but I think the latter has no signing...

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 1, 2016
@stefan-kolb
Copy link
Member Author

Maybe we need an extra certificate issued or registered with the App Store for MacOSX? Needs to be investigated later. For now it works for Windows at least.

# Conflicts:
#	CHANGELOG.md
@stefan-kolb stefan-kolb merged commit 1499e50 into master Dec 2, 2016
@stefan-kolb stefan-kolb deleted the cert branch December 2, 2016 12:18
Siedlerchr added a commit that referenced this pull request Dec 2, 2016
* upstream/master:
  Ignore failing test
  Replace usage of Threads and priorities with thread pool (#2304)
  Class variable declarations and method declarations are now separated by one line
  Disable joining of wrapped lines
  Installer Code Signing #1879 (#2320)
  Add bibtex key deviation check (#2328)
  Update mockito-core (2.2.21 -> 2.2.26) and wiremock (2.3.1 -> 2.4.1)
  Fix opening of preference dialog with Java 9 (#2329)
  Add longer explanation for ID-based entry generation. (#2330)
  Add DOI integrity check (#2327)
  New strings translated (#2325)
  Fix exporting via commandline in no gui mode (#2316)
  Cleanup EMACS code (#2317)
  Update mockito-core from 2.2.15 to 2.2.21
  Fix typo in comment
  Updated JabRef_tr.properties (#2315)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants