-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer Code Signing #1879 #2320
Conversation
stefan-kolb
commented
Nov 29, 2016
- Change in CHANGELOG.md described
- Win
- OSX
LGTM |
Can someone please try this on OSX @chochreiner. I also signed the dmg but I'm not sure that this works with the current certificate (even quite sure that it doesn't). |
hmm |
Which settings do you have for installing applications? For me it is set to "Allow apps downloaded from Mac App Store and identified developers". I think if you use one of the other two settings there will be no differences between the builds... |
For me its: "App Store and identified developers" (on MacOS Sierra) |
Ok.. Now I am confused. Just checked on MacOS Sierra from a colleague and there is no difference between the builds. Maybe it is something about the OS (I am using OS X El Capitan) or I have changed something else which interferes, f.e. disabled SIP to get Spaces back, but this shouldn't make a difference. I can check next week on OS X Mavericks or later today on Mac OS X Snow Leopard.. but I think the latter has no signing... |
Maybe we need an extra certificate issued or registered with the App Store for MacOSX? Needs to be investigated later. For now it works for Windows at least. |
# Conflicts: # CHANGELOG.md
* upstream/master: Ignore failing test Replace usage of Threads and priorities with thread pool (#2304) Class variable declarations and method declarations are now separated by one line Disable joining of wrapped lines Installer Code Signing #1879 (#2320) Add bibtex key deviation check (#2328) Update mockito-core (2.2.21 -> 2.2.26) and wiremock (2.3.1 -> 2.4.1) Fix opening of preference dialog with Java 9 (#2329) Add longer explanation for ID-based entry generation. (#2330) Add DOI integrity check (#2327) New strings translated (#2325) Fix exporting via commandline in no gui mode (#2316) Cleanup EMACS code (#2317) Update mockito-core from 2.2.15 to 2.2.21 Fix typo in comment Updated JabRef_tr.properties (#2315) # Conflicts: # CHANGELOG.md