Reorder checklist in PR template and add "good commit message" #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with Christoph, please put the Changelog entry to the top. After all, no Changelog entry is a blocker for merging most of the time, whereas a missing screenshot is not. |
|
And added tests are more important than manually tried it in JabRef ;-) |
tobiasdiez
approved these changes
Feb 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found https://github.com/joelparkerhenderson/git_commit_message in the net and I really like it. Maybe, we should promote that here, too? WDYT?
I also reordered the checklist at the PR template to go from UI to technical issues. Although the documentation is still the last bullet point.