From 10982a3a728dec22dfe99e71e0c49b4e65124941 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 10 Nov 2019 12:29:48 +0100 Subject: [PATCH 1/3] Make checklist more prominent --- .github/PULL_REQUEST_TEMPLATE.md | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9964ff946df..563c42fb217 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,19 @@ - + +## Checklist ----- +I went through the following checklist and checked all items. All items with `[ ]` are still a TODO. All items checked with `[x]` are done. -- [ ] Change in CHANGELOG.md described -- [ ] Tests created for changes -- [ ] Manually tested changed features in running JabRef +I added new TODOs at the end of the list (if applicable). + +- [ ] Change in CHANGELOG.md described (if applicable) +- [ ] Tests created for changes (if applicable) +- [ ] Manually tested changed features in running JabRef (always required) - [ ] Screenshots added in PR description (for bigger UI changes) - [ ] Ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message) -- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?) +- [ ] Checked documentation status (issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?) From 29ea54ba69db01d0a28444d42ca8fcadd7c145ea Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Sun, 10 Nov 2019 15:03:37 +0100 Subject: [PATCH 2/3] Remove git commit message check --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 563c42fb217..0c22c4c5122 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,5 +15,4 @@ I added new TODOs at the end of the list (if applicable). - [ ] Tests created for changes (if applicable) - [ ] Manually tested changed features in running JabRef (always required) - [ ] Screenshots added in PR description (for bigger UI changes) -- [ ] Ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message) - [ ] Checked documentation status (issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?) From 854870053a29a2c7fd3cdb1c4c25cbd89e63afcb Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Fri, 22 Nov 2019 16:20:39 +0100 Subject: [PATCH 3/3] Result of devcall --- .github/PULL_REQUEST_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 05b15661507..b5ac44d43fb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,12 +5,11 @@ If you fixed a koppor issue, link it with following pattern: [koppor#47](https:/ The title of the PR must not reference an issue, because GitHub does not support autolinking there. --> -## Checklist - [ ] Change in CHANGELOG.md described (if applicable)