Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5939 by creating a mutable list in OpenDatabaseAction #5940

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix #5939 by creating a mutable list in OpenDatabaseAction #5940

merged 1 commit into from
Feb 12, 2020

Conversation

Ka0o0
Copy link
Contributor

@Ka0o0 Ka0o0 commented Feb 12, 2020 •
edited by Siedlerchr
Loading

This PR fixes the problem when opening a library from the recent libraries menu. fixes #5939

  • Change in CHANGELOG.md described (if applicable)
  • Manually tested changed features in running JabRef (always required)

Siedlerchr
Siedlerchr requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just a little suggestion to simplify the code.

src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java Outdated Show resolved Hide resolved
@Ka0o0 Ka0o0 force-pushed the fix-5939-file-history-exception branch from d0f5263 to 6746a9b Compare February 12, 2020 16:55
@Ka0o0 Ka0o0 requested a review from Siedlerchr February 12, 2020 16:56
@Siedlerchr Siedlerchr merged commit 3859620 into JabRef:master Feb 12, 2020
@Siedlerchr
Copy link
Member

Thanks again for your contribution! 👍

@Ka0o0 Ka0o0 deleted the fix-5939-file-history-exception branch February 12, 2020 17:14
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master'
ef4bf81 
* upstream/master:
  Fix #5939 by creating a mutable list in OpenDatabaseAction (#5940)
@koppor
Copy link
Member

koppor commented Mar 13, 2020

We tried it locally. Did not fix the issue. We will switch to List.of().

@stefan-kolb stefan-kolb mentioned this pull request Mar 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when opening library from File History Menu
3 participants
@Ka0o0 @Siedlerchr @koppor