Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Unit Tests for #6207 #6240

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/test/java/org/jabref/logic/integrity/IntegrityCheckTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.util.List;
import java.util.Optional;
import java.util.UUID;
import java.util.stream.Stream;

import org.jabref.logic.bibtexkeypattern.BibtexKeyGenerator;
import org.jabref.logic.bibtexkeypattern.BibtexKeyPatternPreferences;
Expand All @@ -27,13 +28,21 @@

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import org.mockito.Mockito;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;

/**
* This class tests the Integrity Checker as a whole.
* Aspects are: selected fields, issues arising in a complete BibTeX entry, ... When testing a checker works with a certain input,
* this test has to go to a test belonging to the respective checker. See PersonNamesCheckerTest for an example test.
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No empty line between JavaDoc and code.

class IntegrityCheckTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, a JavaDoc should be added explaning the difference between this test and the CheckerTests. Here a proposal:

Suggested change
class IntegrityCheckTest {
/**
* This class tests the Integrity Checker as a whole. Aspects are: selected fields, issues arising in a complete BibTeX entry, ... When testing a checker works with a certain input, this test has to go to a test belonging to the respective checker. See PersonNamesCheckerTest for an example test.
*/
class IntegrityCheckTest {


@Test
Expand All @@ -56,6 +65,33 @@ void bibLaTexAcceptsStandardEntryType() {
assertCorrect(withMode(createContext(StandardField.TITLE, "sometitle", StandardEntryType.Article), BibDatabaseMode.BIBLATEX));
}

@ParameterizedTest
@MethodSource("provideCorrectFormat")
void authorNameChecksCorrectFormat(String input) {
for (Field field : FieldFactory.getPersonNameFields()) {
assertCorrect(withMode(createContext(field, input), BibDatabaseMode.BIBLATEX));
}
}

@ParameterizedTest
@MethodSource("provideIncorrectFormat")
void authorNameChecksIncorrectFormat(String input) {
for (Field field : FieldFactory.getPersonNameFields()) {
assertWrong(withMode(createContext(field, input), BibDatabaseMode.BIBLATEX));
}
}

private static Stream<String> provideCorrectFormat() {
return Stream.of("", "Knuth", "Donald E. Knuth and Kurt Cobain and A. Einstein");
}

private static Stream<String> provideIncorrectFormat() {
return Stream.of(" Knuth, Donald E. ",
"Knuth, Donald E. and Kurt Cobain and A. Einstein",
", and Kurt Cobain and A. Einstein", "Donald E. Knuth and Kurt Cobain and ,",
"and Kurt Cobain and A. Einstein", "Donald E. Knuth and Kurt Cobain and");
}

@Test
void testFileChecks() {
MetaData metaData = mock(MetaData.class);
Expand Down