Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev Doc: Moving around ADR (end?) #6873

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Dev Doc: Moving around ADR (end?) #6873

merged 1 commit into from
Sep 7, 2020

Conversation

mlep
Copy link
Contributor

@mlep mlep commented Sep 4, 2020

gitbook was not collaborative...

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@mlep
Moving around ADR (end?)
59a9927 
gitbook was not collaborative...
@mlep mlep changed the title Moving around ADR (end?) Dev Doc: Moving around ADR (end?) Sep 4, 2020
@Siedlerchr Siedlerchr requested a review from koppor September 5, 2020 11:01
calixtus
calixtus reviewed Sep 5, 2020
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. Could you links the already new ADRs also in the list?

@mlep
Copy link
Contributor Author

mlep commented Sep 6, 2020

It is on my todo list.
I will do it in a different issue.

@koppor
Copy link
Member

koppor commented Sep 7, 2020

We have a little TOC generator tool available at https://adr.github.io/adr-log/. It is not that good, but might be helpful.

@koppor koppor merged commit b640a66 into JabRef:master Sep 7, 2020
@mlep mlep mentioned this pull request Sep 7, 2020
Open
@mlep mlep deleted the patch-5 branch September 10, 2020 14:00
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixCopyPasteCodeArea
897f5e0 
* upstream/master:
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
Siedlerchr added a commit that referenced this pull request Sep 12, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into testEA15Adopt
784c025 
* upstream/master: (55 commits)
  Fix sort order in main table not stored (#6898)
  Window "Manage field names & content": make title consistent with menu (+ localization) (#6895)
  Complete rebranding of `bibtexkey` as `citationkey` (#6875)
  Dev-doc: ADR list (#6887)
  Bump lucene-queryparser from 8.6.1 to 8.6.2 (#6881)
  Bump fontbox from 2.0.20 to 2.0.21 (#6883)
  Bump org.beryx.jlink from 2.21.3 to 2.21.4 (#6882)
  Bump com.github.ben-manes.versions from 0.29.0 to 0.30.0 (#6884)
  Bump pdfbox from 2.0.20 to 2.0.21 (#6885)
  Bump mockito-core from 3.5.7 to 3.5.10 (#6886)
  lint changelog
  Dev Doc: Moving around ADR (end?) (#6873)
  Add MD031 to lint ignore list
  Add mlep's other email adress
  Fetch by ID: SAO/NASA Astrophysics Data System -> SAO/NASA ADS (#6876)
  Reimport -> Reload (#6874)
  GitBook: [master] 19 pages and 4 assets modified
  Add new author
  Delete .Rhistory
  Fix icon issue (#6858)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus left review comments

@koppor koppor Awaiting requested review from koppor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlep @koppor @calixtus