-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify LO connection and fix threading errors #7271
Conversation
Executable is enough
I'm testing the flatpak now.. it should work (like the latex editors..) |
The flatpak JabRef works with the apt/rpm version of libreoffice. EDIT: Is there a file with the configurations that could be edited when building the flatpak? |
@LyzardKing I implemented an approach based on the Env variable you suggested. Alternatively, we could add a variable e.g. |
@Siedlerchr I'll test in the next few days, but this should be enough to have (from the next release) a flatpak that works out of the box with libreoffice/browsers/tex editors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the OO jars now also be removed from the gradle file?
No! The only change is that we no longer need to load the jars from the libre office directory because we already need them for building and running (like other libraries). |
* upstream/master: fix checsktyle Fix for application dialogs opening in wrong displays (#7273) Only disable move to file dir when path equals (#7269) Improved detection of long DOI's within text (#7260) Add missing author and fix name Fix style of highlighted checkboxes while searching in preferences (#7258) Updates to institution citation keys (#7210) Bump xmlunit-core from 2.8.1 to 2.8.2 (#7251) Bump classgraph from 4.8.97 to 4.8.98 (#7250) Bump bcprov-jdk15on from 1.67 to 1.68 (#7249) Bump xmlunit-matchers from 2.8.1 to 2.8.2 (#7252) Bump unirest-java from 3.11.06 to 3.11.09 (#7254) Bump org.beryx.jlink from 2.23.0 to 2.23.1 (#7253) Bump pascalgn/automerge-action from v0.12.0 to v0.13.0 (#7255) # Conflicts: # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
Simplify LO connection
@LyzardKing I simplified the LO connection. It's now enough to input the dir of the executable. JabRef now only calls the soffice.exe
The jars are no longer needed.
Edit// Can you test if the connection to a snap LO or so is now possible?