Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in conversion for small pi #7296

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Fix typo in conversion for small pi #7296

merged 1 commit into from
Jan 4, 2021

Conversation

k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 commented Jan 4, 2021 •
edited
Loading

Fixes #7291. There is a typo in the unicode <-> latex <-> HTML conversion.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
    • Enter "$\pi$ in Abstract field.
    • Convert -> "Unicode to LaTeX" in context menu
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 changed the title Fix typo for small pi Fix typo in conversion for small pi Jan 4, 2021
@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 marked this pull request as ready for review January 4, 2021 21:37
Siedlerchr
Siedlerchr approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@Siedlerchr Siedlerchr merged commit 0d995d6 into JabRef:master Jan 4, 2021
Siedlerchr added a commit that referenced this pull request Jan 5, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into importerbackgroun…
9e7544a 
…dtask

* upstream/master:
  Fix typo for small pi (#7296)
  Fix Normalize pages formatter not replacing dashes (#7243)
  Simplify LO connection and fix threading errors (#7271)
  Fix for issue 7287 (#7290)

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering/conversion of π in Abstract/preview panel
2 participants
@k3KAW8Pnf7mkmdSMPHz27 @Siedlerchr