Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not resize main table columns in search dialog window #8253

Merged
merged 19 commits into from
Nov 28, 2021
Merged

Do not resize main table columns in search dialog window #8253

merged 19 commits into from
Nov 28, 2021

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Nov 15, 2021 •
edited
Loading

Follow up from #8134
Fixes part of #8054

I simply copied the mainTableColumn stuff in the preferences and introduced an interface for usage in the MainTableFactory to pass the individual column preferences

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr requested a review from calixtus November 15, 2021 17:50
@koppor koppor added the status: changes required Pull requests that are not yet complete label Nov 17, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into searchColPrefs
8cf3628 
* upstream/main:
  Add of ADRs 22 and 23 (#8256)
  [Bot] Update CSL styles (#8245)
  Replace styfle/cancel-workflow-action@0.9.1 by GitHub's "concurrency" feature (#8243)
@Siedlerchr
Refactor and store Search Dialog Column changes
0e307a6
@Siedlerchr
checkstyle
19d14ea
@calixtus
Copy link
Member

Please keep in mind to migrate the columnPreferences to the new observable preferences pattern...

@Siedlerchr
refactor, get rid of duplicate column preferences
66555c6
@Siedlerchr
fix checkstlye again
83dfadf
@Siedlerchr
Revert reformatting hazard
c1282f9
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into searchColPrefs
e367b1e 
* upstream/main:
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  Bump mockito-core from 4.0.0 to 4.1.0 (#8267)
  Bump classgraph from 4.8.130 to 4.8.135 (#8268)
  Fix some fetcher tests (#8258)
  Clicking a DOI link in the preview pane no longer crashes (#8255)
@Siedlerchr
fix checkstyle
4452429
@Siedlerchr
Copy link
Member Author

Only problem remains: The library name column's size won't be stored because it's not of type MainTableColumn.
Trying to find a way around this

@Siedlerchr Siedlerchr removed the status: changes required Pull requests that are not yet complete label Nov 22, 2021
@Siedlerchr
Copy link
Member Author

Although the library name column's size is not properly stored this is a huge improvement

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into searchColPrefs
e6453b2 
* upstream/main:
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 25, 2021
calixtus
calixtus approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, can be merged imho, but next step would be to convert the ColumnPreferences to the new prefs model, this would probably make the PersistentVisualState classes superfluous.

@Siedlerchr
Merge remote-tracking branch 'upstream/searchColPrefs' into searchCol…
654b511 
…Prefs

* upstream/searchColPrefs:
  Reverted unnecessary reformatting
@Siedlerchr
fix checkstyle
f01f16f
@Siedlerchr Siedlerchr merged commit 69467d3 into main Nov 28, 2021
@Siedlerchr Siedlerchr deleted the searchColPrefs branch November 28, 2021 19:57
Siedlerchr added a commit that referenced this pull request Nov 30, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jabrefonline
498a8e9 
* upstream/main:
  Consider directory pattern when checking if a file can be moved (#8244)
  Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285)
  Bump unirest-java from 3.13.3 to 3.13.4 (#8283)
  Bump checkstyle from 9.1 to 9.2 (#8284)
  Bump classgraph from 4.8.135 to 4.8.137 (#8282)
  Do not resize main table columns in search dialog window (#8253)
  Fix NegativeArraySizeException (#8270)
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  Bump mockito-core from 4.0.0 to 4.1.0 (#8267)
  Bump classgraph from 4.8.130 to 4.8.135 (#8268)
  Fix some fetcher tests (#8258)
  Clicking a DOI link in the preview pane no longer crashes (#8255)
Siedlerchr added a commit that referenced this pull request Dec 4, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into tinylog
91c1afb 
* upstream/main: (259 commits)
  Fix exception on preview style edit and selection (#8293)
  Fix icon picker excpetion in groups dialog (#8290)
  Add doc tests (#8242)
  fix merge conflict
  Squashed 'buildres/csl/csl-locales/' changes from 0cc3885f61..d5ee85de8e
  Squashed 'buildres/csl/csl-styles/' changes from 3a6a0a7..3bb4b5f
  Consider directory pattern when checking if a file can be moved (#8244)
  Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285)
  Bump unirest-java from 3.13.3 to 3.13.4 (#8283)
  Bump checkstyle from 9.1 to 9.2 (#8284)
  Bump classgraph from 4.8.135 to 4.8.137 (#8282)
  Do not resize main table columns in search dialog window (#8253)
  Fix NegativeArraySizeException (#8270)
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siedlerchr @calixtus @koppor