Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected #8821

Merged
merged 3 commits into from
May 22, 2022
Merged

Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected #8821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98f6c65
Fix #8012 by adding validation before setting value to field that obj…
LIM0000 May 18, 2022
620049a
Merge branch 'main' of https://github.com/LIM0000/jabref into fix-for…
LIM0000 May 22, 2022
c328bb3
Update CHANGELOG.md
LIM0000 May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We fixed an issue where deprecated fields tab is shown when the fields don't contain any values. [#8396](https://github.com/JabRef/jabref/issues/8396)
- We fixed an issue which allow us to select and open identifiers from a popup list in the maintable [#8758](https://github.com/JabRef/jabref/issues/8758), [8802](https://github.com/JabRef/jabref/issues/8802)
- We fixed an issue where the escape button had no functionality within the "Filter groups" textfield. [koppor#562](https://github.com/koppor/jabref/issues/562)
- We fixed an issue where right clicking a group and choose "remove selected entries from this group" leads to error when Bibtex source tab is selected. [#8012](https://github.com/JabRef/jabref/issues/8012)

### Removed

Expand Down
4 changes: 3 additions & 1 deletion src/main/java/org/jabref/gui/entryeditor/SourceTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,9 @@ private void storeSource(BibEntry outOfFocusEntry, String text) {
new FieldWriter(fieldWriterPreferences).write(fieldName, newValue);

compound.addEdit(new UndoableFieldChange(outOfFocusEntry, fieldName, oldValue, newValue));
outOfFocusEntry.setField(fieldName, newValue);
if (outOfFocusEntry.getField(fieldName).isPresent()) {
outOfFocusEntry.setField(fieldName, newValue);
}
}
}

Expand Down