Fix javafx version not displayed in About Dialog #8918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the property is null when javafx is not yet loaded, therefore we check that in the about dialog as well
Siedlerchr
added
the
status: ready-for-review
|
Tested this pr. Looking good :-) JabRef 100.0.0 Hope this is the javafx that JabRef uses and not some random javafx on my system. |
Siedlerchr
added a commit
that referenced
this pull request
Jun 23, 2022
* upstream/main: (27 commits) Add gitpod config (#8921) Fix javafx version not displayed in About Dialog (#8918) Redesign "Manage field names & content" dialog (#8892) Rework IACR fetcher (#8904) Bump h2-mvstore from 2.1.212 to 2.1.214 in /buildSrc (#8915) Bump unoloader from 7.3.3 to 7.3.4 (#8912) Bump libreoffice from 7.3.3 to 7.3.4 (#8913) Bump tika-core from 2.4.0 to 2.4.1 (#8914) Bump org.eclipse.jgit from 6.1.0.202203080745-r to 6.2.0.202206071550-r (#8916) Squashed 'buildres/csl/csl-styles/' changes from e740261..845dee0 (#8903) Bump flowless from 0.6.9 to 0.6.10 (#8898) Bump postgresql from 42.3.5 to 42.4.0 (#8900) Bump mockito-core from 4.6.0 to 4.6.1 (#8899) Bump antlr-runtime from 3.5.2 to 3.5.3 (#8897) Update to MADR 3.0.0-beta.2 (#8896) Increase the network connection timeout and improve error message (#8894) Fix linux terminal opening process error (#8891) Fix exception if linked file has masked umlauts / invalid characters in path (#8851) Remove obsolte CHANGELOG.md entry Revert "Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (#8821)" ... # Conflicts: # build.gradle
Siedlerchr
added a commit
to prashant1712/jabref
that referenced
this pull request
Jun 27, 2022
* upstream/main: Try to make reproducible builds (JabRef#8925) Link to new board (and refine text) Pass the data as a string (JabRef#8923) Add IntelliJ plugins to Gitpod configuration Add gradle support Fix extension name Remove obsolete closing bracket Add gitpod config (JabRef#8921) Fix javafx version not displayed in About Dialog (JabRef#8918) Redesign "Manage field names & content" dialog (JabRef#8892) Rework IACR fetcher (JabRef#8904) Bump h2-mvstore from 2.1.212 to 2.1.214 in /buildSrc (JabRef#8915) Bump unoloader from 7.3.3 to 7.3.4 (JabRef#8912) Bump libreoffice from 7.3.3 to 7.3.4 (JabRef#8913) Bump tika-core from 2.4.0 to 2.4.1 (JabRef#8914) Bump org.eclipse.jgit from 6.1.0.202203080745-r to 6.2.0.202206071550-r (JabRef#8916)
Siedlerchr
added a commit
to LIM0000/jabref
that referenced
this pull request
Jun 28, 2022
* upstream/main: Fix for Dark theme not readable (JabRef#8929) Find Unlinked files should ignore Thumbs.db, etc (JabRef#8800) Try to make reproducible builds (JabRef#8925) Link to new board (and refine text) Pass the data as a string (JabRef#8923) Add IntelliJ plugins to Gitpod configuration Add gradle support Fix extension name Remove obsolete closing bracket Add gitpod config (JabRef#8921) Fix javafx version not displayed in About Dialog (JabRef#8918) Redesign "Manage field names & content" dialog (JabRef#8892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the property is null when javafx is not yet loaded; therefore, we check that in the about dialog as well
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)