Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences dialog now closes on CLOSE DIALOG key binding #9268

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

sjb-ch1mp
Copy link
Contributor

@sjb-ch1mp sjb-ch1mp commented Oct 19, 2022

Fixes #8888

The Preferences dialog was not closing when the CLOSE DIALOG key binding was pressed. This was because when the user changed the tab, they needed to click the Preference Tab List. This ListView was not respecting the event handlers that were present on the dialog. To resolve this, an 'onKeyReleased' event was added to the ListView. The Preferences tab now closes when the CLOSE DIALOG key binding is pressed.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 19, 2022
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution works! LGTM! Needs review from a second dev

@Siedlerchr
Copy link
Member

failing unit tests are related to jitpack error

Copy link
Member

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you for your contribution @sjb-ch1mp!

A minor point is that this only partially fixes #8888, as it only addresses it for one of the ListViews so I'll re-open the issue after this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESC should close the dialog
3 participants