Fixes issue #9281: Let right-click menu more accurately represent selected (sub-)group(s)

[William-Yao0993]

Fixes #9281

Previous discussion about "Remove group" options are presented for clicked group, but actions are taken on all selected groups.

The group passed to removeGroupKeepSubgroups and removeGroupAndSubgroups is only used for dialog text, selectedGroups is used for all actual removals.

---

Proposed solution

---

We assume that the user would like to apply removal only to the current clicked group if the clicked group is not in selectedGroups

• When removeGroupKeepSubgroups() or removeGroupAndSubgroups() are called, check whether the clicked group is presented in selectedGroupds
  • if yes, we do not take anything actions
  • if no, clear selectedGroups and add the current clicked group into selectedGroups

Single group in selectedGroup but does not contain group removal

before removeGroupKeepSubgroups() or removeGroupAndSubgroups():
selectedGroups: test2
group: test3

Steps:

Multi group in seletedGroup but does not contain group

before removeGroupKeepSubgroups() or removeGroupAndSubgroups():
selectedGroups: test1, test2,test3
group: test4

Steps:

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[William-Yao0993]

Hi, could anyone please me some instructions of solving the deployment for macOS. Is it test fail due to my implementation is based on Window system in my local workplace?

"Error: At least one of p12-filepath or p12-file-base64 must be provided"

[Siedlerchr]

Thanks for the pr, you can ignore the failure of the mac tests. It require some signing keys that are only available in the original Jabref repor

[ThiloteE]

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

• close
• closes
• closed
• fix
• fixes
• fixed
• resolve
• resolves
• resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

[William-Yao0993]

Thanks for your suggestion. May I please ask is there anything in our implementation need be improved? We would like to have some feedback.

[calixtus]

Thanks for your interest in JabRef programming. After taking a quick look into your solution, this seems to be rather a workaround, but a solution. Before deciding on this issue, i think its best to have some comparisons, eg. how does windows explorer or mac or any other file manager handle the case, that the right click happens not on the entry, which is selected?

[calixtus]

Can you please offer some insight in your rationale and provide some examples, how windows explorer or other applications handle right-click on a list?
What's the status here?

[calixtus]

I sorry to see you may have lost interest in fixing this issue. Would be still great though if this issue could be fixed. Maybe someone else is interested looking into best practices on right click handling in lists?