Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bibtex month not deprecated #9404

Merged
merged 9 commits into from
Dec 18, 2022
Merged

Bibtex month not deprecated #9404

merged 9 commits into from
Dec 18, 2022

Conversation

svenjaeger
Copy link
Contributor

@svenjaeger svenjaeger commented Nov 25, 2022 •
edited by koppor
Loading

Fixes #7757

This is about #7757. With these changes, the month is not shown as deprecated in BibTeX mode any more, but I am not sure whether anything is shown in this tab at all, now.

This obviously depends on the line
deprecatedFields.retainAll(getOptionalFieldsAndAliases());
that seems to filter out everything now.

@koppor koppor marked this pull request as draft November 26, 2022 23:01
@koppor koppor marked this pull request as ready for review December 12, 2022 23:54
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 12, 2022
@koppor
Copy link
Member

koppor commented Dec 17, 2022

BibTeX

Before the PR:

grafik

After the PR:

grafik

biblatex

Before the PR:

grafik

After the PR:

grafik

svenjaeger and others added 4 commits December 18, 2022 08:22
@svenjaeger
reformating according to review comment
790b1d9
@koppor
Merge remote-tracking branch 'origin/main' into bibtex-month-not-depr…
b30dc4c 
…ecated
@koppor @Siedlerchr @calixtus
Show "deprecated fields" tab only in biblatex-mode
0910630 
- Add paramter "mode" to getSecondaryOptionalNotDeprecatedFields
- More advanced tool tip
- Make variable name in EntryConverter more readable

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor
Merge branch 'fix-7757' into bibtex-month-not-deprecated
d20085a
@koppor koppor force-pushed the bibtex-month-not-deprecated branch from 771c16c to d20085a Compare December 18, 2022 23:17
@koppor
Copy link
Member

koppor commented Dec 18, 2022

Thank you for the PR. me, @calixtus, and @Siedlerchr hat a long discussion about the meaning of "deprecated" in that context. We agreed that it is "only" about biblatex. When a user aims for using biblatex, they want to know which fields they should not use any more. We also thought that year is still used in biblatex. However, when "month" is also used, JabRef now adds "month" to the deprecated tab and shows a hint that date should be used.

@calixtus calixtus changed the title [wip]Bibtex month not deprecated Bibtex month not deprecated Dec 18, 2022
@Siedlerchr Siedlerchr merged commit e8c3a42 into JabRef:main Dec 18, 2022
svenjaeger
svenjaeger commented Dec 19, 2022
View reviewed changes
src/main/java/org/jabref/model/entry/BibEntryType.java
if (EntryConverter.FIELD_ALIASES_LTX_TO_TEX.containsKey(field.getField())) {
optionalFieldsAndAliases.add(EntryConverter.FIELD_ALIASES_LTX_TO_TEX.get(field.getField()));
if (EntryConverter.FIELD_ALIASES_BIBTEX_TO_BIBLATEX.containsKey(field.getField())) {
optionalFieldsAndAliases.add(field.getField());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intention here? Now, for each optional field, we first add it to optionalFieldsAndAliases, and if it is contained in FIELD_ALIASES_BIBTEX_TO_BIBLATEX, then we add it a second time.

Siedlerchr added a commit to MaryJml/jabref that referenced this pull request Dec 19, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into import_into_library
9e1fcf4 
* upstream/main: (75 commits)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479)
  Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480)
  Bibtex month not deprecated (JabRef#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  Also trigger on branch arm64mac-release
  Only arm64 m+
  Update deployment-arm64.yml
  add deployment with arm as well
  Revert "Test self hosted runner"
  remove self hosted from normal deployment
  fix unit test for slr
  Refine do not put under drive letter
  Update journal abbrev list (JabRef#9469)
  ...

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit to VernonKwa/jabref-Exception- that referenced this pull request Dec 19, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Add-log-for-ignored…
fcea58d 
…-excepton

* upstream/main: (184 commits)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479)
  Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480)
  Bibtex month not deprecated (JabRef#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  Also trigger on branch arm64mac-release
  Only arm64 m+
  Update deployment-arm64.yml
  add deployment with arm as well
  Revert "Test self hosted runner"
  remove self hosted from normal deployment
  fix unit test for slr
  Refine do not put under drive letter
  Update journal abbrev list (JabRef#9469)
  ...

# Conflicts:
#	src/main/java/org/jabref/logic/remote/server/RemoteListenerServer.java
Siedlerchr added a commit to rafatd/jabref that referenced this pull request Dec 20, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into enable_drag'n'drop_…
0daff49 
…of_groups_to_new_library

* upstream/main: (148 commits)
  Fix remember last open valid library with empty new one (JabRef#9489)
  Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486)
  Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485)
  New Crowdin updates (JabRef#9483)
  Add log for ignored excepton (JabRef#9302)
  Select Library to import into (JabRef#9402)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479)
  Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480)
  Bibtex month not deprecated (JabRef#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  Also trigger on branch arm64mac-release
  Only arm64 m+
  Update deployment-arm64.yml
  ...
Siedlerchr added a commit to shafinkamal/jabref that referenced this pull request Dec 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8729
f95130c 
* upstream/main: (145 commits)
  Enable groups drag'n'drop to new library (JabRef#9460)
  Update MacOS jabrefHost.py to find local installs (JabRef#9487)
  Fix remember last open valid library with empty new one (JabRef#9489)
  Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486)
  Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485)
  New Crowdin updates (JabRef#9483)
  Add log for ignored excepton (JabRef#9302)
  Select Library to import into (JabRef#9402)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479)
  Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480)
  Bibtex month not deprecated (JabRef#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  Also trigger on branch arm64mac-release
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/java/org/jabref/preferences/JabRefPreferences.java
Siedlerchr added a commit to Freeman6475/jabref that referenced this pull request Dec 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-JabRef#6448
06aa986 
* upstream/main: (120 commits)
  Enable groups drag'n'drop to new library (JabRef#9460)
  Update MacOS jabrefHost.py to find local installs (JabRef#9487)
  Fix remember last open valid library with empty new one (JabRef#9489)
  Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486)
  Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485)
  New Crowdin updates (JabRef#9483)
  Add log for ignored excepton (JabRef#9302)
  Select Library to import into (JabRef#9402)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479)
  Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480)
  Bibtex month not deprecated (JabRef#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  Also trigger on branch arm64mac-release
  ...
Siedlerchr added a commit that referenced this pull request Dec 25, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into update_jdk
c6dcead 
* upstream/main: (75 commits)
  Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493)
  Enable groups drag'n'drop to new library (#9460)
  Update MacOS jabrefHost.py to find local installs (#9487)
  Fix remember last open valid library with empty new one (#9489)
  Observable Preferences R (CitationKeyPatternPreferences) (#9486)
  Fixed ZBMathTest and extracted keyWordSeparator (#9485)
  New Crowdin updates (#9483)
  Add log for ignored excepton (#9302)
  Select Library to import into (#9402)
  Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (#9476)
  Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (#9478)
  Bump mockito-core from 4.9.0 to 4.10.0 (#9479)
  Bump checkstyle from 10.4 to 10.5.0 (#9477)
  Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (#9480)
  Bibtex month not deprecated (#9404)
  Show development information\n\n+semver: major
  Release v5.8
  Update external libraries add afterburner fx jabref add jakarta inject
  fix display name for artifact store
  Prepare CHANGELOG for release
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
entry-editor status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated fields are not deprecated (in BibTeX mode)
5 participants
@svenjaeger @koppor @Siedlerchr @calixtus @ThiloteE