Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to output audio to non-default audio devices #10

Open
JackDotJS opened this issue Jul 7, 2022 · 4 comments
Open

Option to output audio to non-default audio devices #10

JackDotJS opened this issue Jul 7, 2022 · 4 comments
Labels
enhancements improvements for existing features typescript anything that largely involves JavaScript/TypeScript code

Comments

@JackDotJS
Copy link
Owner

https://github.com/almoghamdani/audify

found through this thread: electron/electron#13771

@JackDotJS JackDotJS added the enhancements improvements for existing features label Nov 6, 2022
@JackDotJS
Copy link
Owner Author

will need to find a different solution since we are no longer using electron

@JackDotJS JackDotJS modified the milestones: Node Studio 1.x, Post-Release Stuff Dec 6, 2022
@JackDotJS
Copy link
Owner Author

this might be possible with built-in web APIs.

https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/enumerateDevices
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/setSinkId

only issue is that it explicitly requires the user to give permission via a lil popup before we can access this data. awesome for privacy reasons, but it does add an extra step for the end user and could come off as slightly jarring and annoying. most people probably wouldn't expect to have to give permission like that for most desktop applications.

on the bright side, it seems the user would only have to give permission once.

@JackDotJS JackDotJS added the typescript anything that largely involves JavaScript/TypeScript code label Dec 18, 2022
@JackDotJS
Copy link
Owner Author

also worth noting getUserMedia() grants microphone access as well, which could be used for recording instrument/voice samples and stuff. so there's a good chance we'll be using this API either way

@JackDotJS
Copy link
Owner Author

last comment i promise

another issue is that if the user were to deny the permission, we will not be able to ask again, ever.

on regular browsers, this can be fixed by going into settings and removing the given website from a "permissions blacklist". but i have absolutely no idea if or how you could do this in the context of OS native web renderers that Tauri uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements improvements for existing features typescript anything that largely involves JavaScript/TypeScript code
Projects
Status: 📋 More Info Required
Development

No branches or pull requests

1 participant