Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label rendering #206

Draft
wants to merge 14 commits into
base: 1.21.1
Choose a base branch
from

Conversation

ash-development
Copy link

i can't say it is very pretty code, but it fixes #196 :3

the label will render in front of the chest

@ash-development
Copy link
Author

i can confirm that this works with chests, shulker boxes & barrels. shulker boxes sometimes don't have their labels update when blocks are placed on top, but barrels and chests do so 🤷🏼‍♀️ shulkers must have some funny logic

@ash-development ash-development marked this pull request as ready for review August 16, 2024 06:28
@ash-development ash-development marked this pull request as draft September 14, 2024 03:10
@ash-development
Copy link
Author

Converted to draft to merge new repo changes into the feature. It is also planned to make this toggable-able.

@JackFred2
Copy link
Owner

Will wait for the new setting code to get on the PR before anything, but a couple thoughts on the previous ver:

Some containers might not have a FACING or FACING_HORIZONTAL value to offset from (none in vanilla that I know, but some mods might). A fallback might be just having it in the center of the block. (v1 behavior)

Might be worth having an Enum option instead, where the options are above (default), in front (with center as fallback), or in the center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container label still inside block(s) above
2 participants