Combine ingredients in shopping lists #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to a consistent internal representation. When dealing with units, we remove ambiguity at parse-time and never have to deal with synonyms internally. This has the disadvantage that units aren't presented exactly as the user entered them (arguably an advantage). It leads to more compile-time guarantees, when dealing with units GHC can now make sure our cases are exhaustive.
They can't find their dependent modules. Not sure why.
Users can just run "cabal doctest"
This was referenced Aug 25, 2018
|
Note that this introduces a backwards-incompatible change: units in already-defined recipes files will have to be modified. |
app/herms.hs
Outdated
| @@ -378,7 +377,7 @@ servingP t = option auto | |||
| <> short Str.servingShort | |||
| <> help (t Str.servingDesc) | |||
| <> showDefault | |||
| <> value 0 | |||
| <> value 1 | |||
There was a problem hiding this comment.
Oh, I didn't meant to change this.
|
This isn't quite ready:
|
|
Wow! This is quite an update!!! I'm loving it! Is this ready to be merged? |
|
Not quite yet! I will finish it soon, likely tomorrow. All those changes should be quite small (~15 lines total), so feel free to give it a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reifying units to a type
Combining ingredients
This is the goal of the reification. If you have two units with the same names and units, say:
It will be displayed in a shopping list as:
So it is even smart about combining attributes in a way that the user can recover all the original data 😄
Reorganization and cleanup
AddCLIis definitely not a library module, it defines a UIcabal doctest, which will do everything this code currently does automatically)