Links to definition in source fail to load

[AndrewADev]

Currently, clicking on a link on a link to the location of a definition:

...leads to a non-working page:

...because GitHub's CSP prevents use of iframes

...one of which is used in the main API docs component.

Possible fix:

For the markup itself, the change is as simple as not trying to display GitHub content within an <iframe>, instead using something else, likely a <div> (screenshot from the TypeDoc example site):

But as this iframe is currently pointing to an html file hosted on GitHub pages, there would certainly be more changes needed as well.

[JamesLMilner]

Thanks for raising this @AndrewADev, appreciated. This is an issue I hadn't noticed - I think the best option is to disable it for now via the disablesSources flag, although this feels like a shame. Another option would be to post process the output to make all the links of this type open in a new tab, although that would be quite laborious.

I've raised an issue on TypeDoc to ask if it's possible to add a flag to enable opening these links in another tab that you can see here: TypeStrong/typedoc#2415

[JamesLMilner]

@AndrewADev this should be resolved now just to the addition of the upstream flag to open links in a new tab 👍🏻