Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use types export in package.json #218

Conversation

maksnester
Copy link
Contributor

@maksnester maksnester commented May 29, 2024

This is to provide TS based autocomplete for config fields when type is used like this

/** @type {import("syncpack").RcFile} */
const config = {
  sortFirst: ['name', 'description', 'version', 'scripts'],
};

Without this PR RcFile type can not be resolved.

@maksnester maksnester changed the title fix: use types exort in package.json fix: use types export in package.json May 29, 2024
@JamieMason
Copy link
Owner

Nice find, thanks Maksim 👍

@joshmeads
Copy link

Any chance we can get this merged? Currently the example config in the docs includes:

/** @type {import("syncpack").RcFile} */

This doesn't work without this change and leads users to assume something is wrong on their end.

Thanks guys!

@JamieMason
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants