Lps 203810 1 8 pr2 sf #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-203810-1-8-pr2-sf 1 Failed Jobs:For more details click here. [java] java.lang.Exception: Found 2 formatting issues:
[java] 1: Incorrect commit message in SHA 2e0a403a20ac0630aa7df3f218ed5eab1ea3eeaa: 'portal-kernel/src/com/liferay/portal/kernel/template/TemplateNode.java' points to nonexistent file. '## What' should be followed by only one path, which is from https://github.com/liferay/liferay-portal/blob/master/.: ./portal-impl/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
[java] 2: Incorrect commit message in SHA 2e0a403a20ac0630aa7df3f218ed5eab1ea3eeaa: 'portal-kernel/src/com/liferay/portal/kernel/template/TemplateNode.java' points to nonexistent file. '## What' should be followed by only one path, which is from https://github.com/liferay/liferay-portal/blob/master/.: ./portal-kernel/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
[java]
[java] at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:458)
[java] at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:291)
[stopwatch] [run.batch.test.action: 1:55.576 sec]
[echo] The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:504: The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:648: Java returned: 1
[get] Getting: http://test-1-26/job/test-portal-source-format/7420//consoleText
[get] To: /opt/dev/projects/github/liferay-portal/20240107214606020.txt
[delete] Deleting: /opt/dev/projects/github/liferay-portal/20240107214606020.txt
[typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
[taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
[delete] Deleting: /opt/dev/projects/github/liferay-portal/null2128316948.properties
|
…re for next. # breaking ## What portal-kernel/src/com/liferay/portal/kernel/templateparser/TemplateNode.java We move TemplateNode from portal-kernel to portal-impl ## Why We are merging portal-kernel into portal-impl as a long term goal to simplify portal structure. ## Alternatives Add portal-impl in build dependency and use the same class. ----
…al-impl, prepare for next. # breaking ## What portal-kernel/src/com/liferay/document/library/kernel/store/StoreAreaAwareStoreWrapper.java We move StoreAreaAwareStoreWrapper from portal-kernel to portal-impl ## Why We are merging portal-kernel into portal-impl as a long term goal to simplify portal structure. ## Alternatives Add portal-impl in build dependency and use the same class. ----
… next. # breaking ## What portal-kernel/src/com/liferay/document/library/kernel/util/DLUtil.java We move DLUtil from portal-kernel to portal-impl ## Why We are merging portal-kernel into portal-impl as a long term goal to simplify portal structure. ## Alternatives Add portal-impl in build dependency and use the same class. ----
# breaking ## What portal-impl/src/com/liferay/portlet/documentlibrary/util/DLImpl.java DLImpl is being removed. ## Why We want to eliminate spring bean DLImpl and DLUtil ## Alternatives Use DLUtil instead. ----
… prepare for removing DL interface. # breaking ## What portal-kernel/src/com/liferay/portal/kernel/repository/BaseRepositoryImpl.java We move BaseRepositoryImpl from portal-kernel to portal-impl ## Why We are merging portal-kernel into portal-impl as a long term goal to simplify portal structure. ## Alternatives Add portal-impl in build dependency and use the same class. ----
… for removing DL interface # breaking ## What portal-kernel/src/com/liferay/portal/kernel/webdav/WebDAVUtil.java We move WebDAVUtil from portal-kernel to portal-impl ## Why We are merging portal-kernel into portal-impl as a long term goal to simplify portal structure. ## Alternatives Add portal-impl in build dependency and use the same class. ----
# breaking ## What portal-kernel/src/com/liferay/document/library/kernel/util/DLUtil.java Remove getDL method from DLUtil.java ## Why No one is using it. ----
… DLImpl from document-library-spring.xml # breaking ## What portal-kernel/src/com/liferay/document/library/kernel/util/DLUtil.java Remove setDL method from DLUtil.java ## Why No one is using it. ----
… usages # breaking ## What portal-kernel/src/com/liferay/document/library/kernel/util/DL.java DL interface is being removed. ## Why DL interface is no longer needed since we do not need Spring to register its implementation as OSGi component anymore. ## Alternatives Use DLUtil directly. ----
JanisZhang
force-pushed
the
LPS-203810-1-8-pr2-sf
branch
from
864bfad to
5ed4686
Compare
|
ci:test:sf |
|
Jenkins Build:test-portal-source-format#7420 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:JanisZhang#264 Testray Routine:EE Pull Request Testray Build ID:2483959748 Testray Importer:publish-testray-report#29019 |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-203810-1-8-pr2-sf 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#2451 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:JanisZhang#264 Testray Routine:EE Pull Request Testray Build ID:2483959892 Testray Importer:publish-testray-report#10353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.