Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Save warning does not have proper fallback #1763

Closed
CherryLax opened this issue Feb 23, 2023 · 2 comments
Closed

[Issue] Save warning does not have proper fallback #1763

CherryLax opened this issue Feb 23, 2023 · 2 comments
Labels
bug An issue, where the program does not do what it is supposed to

Comments

@CherryLax
Copy link

CherryLax commented Feb 23, 2023

The pop up window asking "Do you want to save your model?" has three options: Save, Discard, and Cancel. When you choose Discard, the changes are discarded and you are brought back to the home page. Unfortunately, this is what also happens when you choose Cancel. I expect that the intended function of the Cancel button is to bring you back to the model without saving or discarding any changes.

To recreate this, open a saved JSON model, make any change, then close the tab to get the window.

Thank you for the great program. I hope you are able to patch up this small oversight to make it even better.

Model format in which the issue occurs

Java Block/Item

Blockbench variant

Program

Operating System

Windows 11

@JannisX11
Copy link
Owner

I cannot reproduce this issue. Can you check if you have any related console errors? (Help > Developer > Open Dev Tools > Console)

@CherryLax
Copy link
Author

CherryLax commented Feb 25, 2023

Oh you're right, I gave you the wrong instructions 😅

Try this:
Open a saved JSON model, make any change, then close the tab to get the window. After that press save and THEN press cancel.

This happens when I forget to save before closing, then when I try to save the only option is to save as a Blockbench project when I really want to continue using the JSON format. So naturally, I cancel so I can save it in the correct format. This is when all the changes are discarded.

I hope that helps clear things up!

@JannisX11 JannisX11 added the bug An issue, where the program does not do what it is supposed to label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue, where the program does not do what it is supposed to
Projects
None yet
Development

No branches or pull requests

2 participants