Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certmanager): handle issues reported by CodeQL #160

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Dec 10, 2021

Overview:

  • fix implicit string concatenation in a list
  • remove variable that defined multiple times
  • refactor options handler

@iromli iromli requested a review from moabu as a code owner December 10, 2021 20:40
@iromli iromli linked an issue Dec 10, 2021 that may be closed by this pull request
@moabu moabu added comp-docker-jans-certmanager kind-bug Issue or PR is a bug in existing functionality kind-enhancement Issue or PR is an enhancement to an existing functionality labels Dec 23, 2021
@moabu moabu added this to the 1.0.0 milestone Dec 23, 2021
@moabu moabu merged commit f5037af into master Dec 23, 2021
@moabu moabu deleted the cn-fix-certmanager branch December 23, 2021 11:23
moabu pushed a commit that referenced this pull request Jan 13, 2022
…8a4f4a7e3dd5de09f99d85248bb102

Revert "[Snyk] Upgrade org.apache.httpcomponents:httpcore from 4.4.5 to 4.4.14"
moabu pushed a commit that referenced this pull request Jan 13, 2022
* fix(certmanager): avoid implicit string concat in a list

* refactor(certmanager): remove variable that defined multiple times

* refactor(certmanager): parse passed options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-docker-jans-certmanager kind-bug Issue or PR is a bug in existing functionality kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit string concatenation in a list
2 participants