Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-orm): use iterator to correctly to remove OC attribute #2138

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix(jans-orm): use iterator to correctly to remove OC attribute #2138

merged 1 commit into from
Aug 15, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Aug 15, 2022 •
edited
Loading

Prepare

Description

Fixed ORM ConcurrentModificationException issue while token generation

Target issue

closes #2137

closes #issue-number-here

Implementation Details

Fixed attribute iteration logic

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-orm Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Aug 15, 2022
@yurem yurem merged commit b590981 into main Aug 15, 2022
@yurem yurem deleted the fix_oc_attribute_remove branch August 15, 2022 16:46
ossdhaval pushed a commit that referenced this pull request Aug 16, 2022
@pujavs @yurem @ossdhaval
fix: use iterator to correcly remove OC attribute (#2138)
ee75e6e 
Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@mo-auto mo-auto mentioned this pull request Aug 30, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
@mo-auto mo-auto mentioned this pull request Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

Assignees
No one assigned
Labels
comp-jans-orm Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-orm): fix ConcurrentModificationException issue while authentication
3 participants
@pujavs @yurem @mo-auto