Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-config-api): issues in updating the default authentication method #2228

Closed
moabu opened this issue Aug 26, 2022 · 2 comments · Fixed by #2443
Closed

fix(jans-config-api): issues in updating the default authentication method #2228

moabu opened this issue Aug 26, 2022 · 2 comments · Fixed by #2443
Assignees
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone

Comments

@moabu
Copy link
Member

moabu commented Aug 26, 2022

Updating the default authentication method

  • unhandled NPE when providing null value for /jans-config-api/api/v1/acrs (which was the initial value)

    26-08 07:45:39.953 INFO  jans.configapi.filters.LoggingFilter LoggingFilter.java:33- ****Request PUT /acrs from IP 176.199.211.208
    2022-08-26 07:45:39.970:WARN :oejs.HttpChannel:qtp762476028-147: /jans-config-api/api/v1/acrs
    org.jboss.resteasy.spi.UnhandledException: java.lang.NullPointerException
        at org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:105)
        ...
    
  • 500 error when updating /jans-config-api/api/v1/acrs with empty DefaultAcr value

    2022-08-26 08:04:04.863:WARN :oejs.HttpChannel:qtp762476028-21: /jans-config-api/api/v1/acrs
    org.jboss.resteasy.spi.UnhandledException: jakarta.validation.ConstraintViolationException: 1 constraint violation(s) occurred during method validation.|Constructor or Method: public jakarta.ws.rs.core.Response io.jans.configapi.rest.resource.auth.AcrsResource.updateDefaultAuthenticationMethod(io.jans.configapi.rest.model.AuthenticationMethod)|Argument values: [AuthenticationMethod [ defaultAcr=]]|Constraint violations: | (1) Kind: PROPERTY| message: size must be between 1 and 2147483647| root bean: io.jans.configapi.rest.resource.auth.AcrsResource$Proxy$_$$_WeldSubclass@29f9777d| property path: updateDefaultAuthenticationMethod.authenticationMethod.defaultAcr| constraint: @jakarta.validation.constraints.Size(groups={}, min=1, message="{jakarta.validation.constraints.Size.message}", max=2147483647, payload={})
        at org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:105)
        ...
    

Effectively, it is not possible for me to change the config back to it's original value.

@moabu moabu self-assigned this Aug 26, 2022
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Aug 26, 2022
@moabu moabu assigned pujavs and unassigned moabu Aug 27, 2022
@moabu moabu modified the milestones: 1.0.2, 1.0.3 Aug 29, 2022
@pujavs
Copy link
Contributor

pujavs commented Sep 9, 2022

able to replicate this issue, working on the same

@pujavs
Copy link
Contributor

pujavs commented Sep 22, 2022

Fixed via PR 2443
Testing: Issue_2228.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants