Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker-jans-configurator): allow user-defined salt #3624

Merged
merged 3 commits into from
Jan 20, 2023
Merged

feat(docker-jans-configurator): allow user-defined salt #3624

merged 3 commits into from
Jan 20, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jan 13, 2023

Prepare

Description

Target issue

closes #3622

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner January 13, 2023 22:42
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-configurator kind-feature Issue or PR is a new feature request labels Jan 13, 2023
moabu
moabu previously approved these changes Jan 14, 2023
View reviewed changes
docker-jans-configurator/README.md Show resolved Hide resolved
@moabu moabu merged commit cf743b7 into main Jan 20, 2023
@moabu moabu deleted the cn-user-defined-salt branch January 20, 2023 16:06
@mo-auto2 mo-auto2 mentioned this pull request Feb 22, 2023
Merged
@mo-auto3 mo-auto3 mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-configurator kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(docker-jans-configurator): allow user-defined salt
3 participants
@iromli @moabu @mo-auto