Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans-persistence-loader): rename smtp config keys #4528

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix(docker-jans-persistence-loader): rename smtp config keys #4528

merged 1 commit into from
Apr 14, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Apr 7, 2023

Prepare

Description

Target issue

closes #4522

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner April 7, 2023 15:11
@mo-auto mo-auto added comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality labels Apr 7, 2023
@moabu
Copy link
Member

moabu commented Apr 14, 2023

A new issue should be open to track adding a rotating job for the smtp keys

@moabu moabu merged commit f0c3045 into main Apr 14, 2023
@moabu moabu deleted the cn-smtp-config branch April 14, 2023 08:46
@mo-auto2 mo-auto2 mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans-persistence-loader): rename smtp config keys
3 participants
@iromli @moabu @mo-auto