Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update authenticate method for step 1 #8506

Merged
merged 2 commits into from
May 14, 2024
Merged

fix: update authenticate method for step 1 #8506

merged 2 commits into from
May 14, 2024

Conversation

jgomer2001
Copy link
Contributor

@jgomer2001 jgomer2001 commented May 14, 2024 •
edited by mo-auto
Loading

Prepare

Description

Target issue

closes #8480

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #8508,

@jgomer2001
fix: update authenticate method for step 1 #8480
c96367d 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@jgomer2001 jgomer2001 requested a review from maduvena as a code owner May 14, 2024 15:40
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label May 14, 2024
@moabu moabu closed this May 14, 2024
@moabu moabu reopened this May 14, 2024
@moabu moabu merged commit 271e195 into main May 14, 2024
2 checks passed
@moabu moabu deleted the jans-casa-issue_8480 branch May 14, 2024 16:22
@mo-auto
Copy link
Member

mo-auto commented May 14, 2024

Error: Hi @jgomer2001, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request May 14, 2024
Closed
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@jgomer2001 @moabu
fix: update authenticate method for step 1 (#8506)
90a7b78 
fix: update authenticate method for step 1 #8480

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: 271e195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@maduvena maduvena Awaiting requested review from maduvena maduvena is a code owner

Assignees
No one assigned
Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@jgomer2001 @mo-auto @moabu